Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

2016-09-20 Thread Paolo Bonzini
On 19/09/2016 21:06, Emilio G. Cota wrote: > Let me then just point out that this comes at a small perf loss. > > Running 'taskset -c 0 tests/qht-bench -n 1 -d 10' (i.e. all lookups) 10 times, > we get: > > before the patch: > $ ./mean.pl 34.04 34.24 34.38 34.25 34.18 34.51 34.46 34.44 34.29

Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

2016-09-19 Thread Emilio G. Cota
On Mon, Sep 19, 2016 at 20:37:06 +0200, Paolo Bonzini wrote: > On 19/09/2016 20:06, Emilio G. Cota wrote: > > On Mon, Sep 19, 2016 at 16:51:38 +0100, Alex Bennée wrote: > >> > ThreadSanitizer detects a possible race between reading/writing the > >> > hashes. As ordering semantics are already

Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

2016-09-19 Thread Paolo Bonzini
On 19/09/2016 20:06, Emilio G. Cota wrote: > On Mon, Sep 19, 2016 at 16:51:38 +0100, Alex Bennée wrote: >> > ThreadSanitizer detects a possible race between reading/writing the >> > hashes. As ordering semantics are already documented for qht we just >> > need to ensure a race can't tear the

Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

2016-09-19 Thread Emilio G. Cota
On Mon, Sep 19, 2016 at 16:51:38 +0100, Alex Bennée wrote: > ThreadSanitizer detects a possible race between reading/writing the > hashes. As ordering semantics are already documented for qht we just > need to ensure a race can't tear the hash value so we can use the > relaxed atomic_set/read