Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

Hey Richard, I think I submitted the wrong patch, sorry about that. I will go ahead and submit the correct commit id now. What I was trying to do was, when kvm is enabled and if we don't want to include CONFIG_ARM_VIRT or CONFIG_ACPI_APEI, compilation fails as virt_is_acpi_enabled() routine is

Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

On 5/24/21 3:56 PM, Swetha Joshi wrote: From: Swetha Signed-off-by: Swetha What are you trying to accomplish? That's what belongs in the commit message that you omitted. +bool acpi_enabled = false; +#ifdef CONFIG_ARM_VIRT bool acpi_enabled = virt_is_acpi_enabled(vms); Of

Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

Patchew URL: https://patchew.org/QEMU/20210524225608.3191809-1-swethajoshi...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210524225608.3191809-1-swethajoshi...@gmail.com Subject: [PATCH] Adding ifdefs

[PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

From: Swetha Signed-off-by: Swetha --- target/arm/kvm64.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index dff85f6db9..724ce78265 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1403,7 +1403,10 @@ void