Re: [PATCH] Fix some typos in documentation and comments
30.07.2023 21:03, Stefan Weil via wrote: Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with the same typos were fixed, too. I think the patch is trivial, so maybe it can still be included in the upcoming release, but that's not strictly necessary. Stefan docs/about/deprecated.rst| 2 +- docs/devel/qom.rst | 2 +- docs/system/devices/nvme.rst | 2 +- hw/core/loader.c | 4 ++-- include/exec/memory.h| 2 +- ui/vnc-enc-tight.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 1c35f55666..92a2bafd2b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -369,7 +369,7 @@ mapping permissions et al by using its 'mapped' security model option. Nowadays it would make sense to reimplement the ``proxy`` backend by using QEMU's ``vhost`` feature, which would eliminate the high latency costs under which the 9p ``proxy`` backend currently suffers. However as of to date nobody -has indicated plans for such kind of reimplemention unfortunately. +has indicated plans for such kind of reimplementation unfortunately. FWIW, all these changes has been included in my "tree-wide spelling" series. This particular change: https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg03011.html /mjt
Re: [PATCH] Fix some typos in documentation and comments
On 30/7/23 20:03, Stefan Weil wrote: Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with the same typos were fixed, too. I think the patch is trivial, so maybe it can still be included in the upcoming release, but that's not strictly necessary. Stefan docs/about/deprecated.rst| 2 +- docs/devel/qom.rst | 2 +- docs/system/devices/nvme.rst | 2 +- hw/core/loader.c | 4 ++-- include/exec/memory.h| 2 +- ui/vnc-enc-tight.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) Thanks, queued via misc-fixes.
Re: [PATCH] Fix some typos in documentation and comments
On 30/7/23 20:03, Stefan Weil wrote: Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments with the same typos were fixed, too. I think the patch is trivial, so maybe it can still be included in the upcoming release, but that's not strictly necessary. Stefan docs/about/deprecated.rst| 2 +- docs/devel/qom.rst | 2 +- docs/system/devices/nvme.rst | 2 +- hw/core/loader.c | 4 ++-- include/exec/memory.h| 2 +- ui/vnc-enc-tight.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH] Fix some typos in documentation and comments
On Sun, 30 Jul 2023 at 19:55, Stefan Weil via wrote: > > Signed-off-by: Stefan Weil > --- Reviewed-by: Peter Maydell thanks -- PMM
[PATCH] Fix some typos in documentation and comments
Signed-off-by: Stefan Weil
---
This patch was triggered by a spelling check for the generated
QEMU documentation using codespell. It does not try to fix all
typos which still exist in the QEMU code, but has a focus on
those required to fix the documentation. Nevertheless some code
comments with the same typos were fixed, too.
I think the patch is trivial, so maybe it can still be included
in the upcoming release, but that's not strictly necessary.
Stefan
docs/about/deprecated.rst| 2 +-
docs/devel/qom.rst | 2 +-
docs/system/devices/nvme.rst | 2 +-
hw/core/loader.c | 4 ++--
include/exec/memory.h| 2 +-
ui/vnc-enc-tight.c | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 1c35f55666..92a2bafd2b 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -369,7 +369,7 @@ mapping permissions et al by using its 'mapped' security
model option.
Nowadays it would make sense to reimplement the ``proxy`` backend by using
QEMU's ``vhost`` feature, which would eliminate the high latency costs under
which the 9p ``proxy`` backend currently suffers. However as of to date nobody
-has indicated plans for such kind of reimplemention unfortunately.
+has indicated plans for such kind of reimplementation unfortunately.
Block device options
diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index 0b506426d7..9918fac7f2 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -30,7 +30,7 @@ user configuration.
Creating a QOM class
-A simple minimal device implementation may look something like bellow:
+A simple minimal device implementation may look something like below:
.. code-block:: c
:caption: Creating a minimal type
diff --git a/docs/system/devices/nvme.rst b/docs/system/devices/nvme.rst
index a8bb8d729c..2a3af268f7 100644
--- a/docs/system/devices/nvme.rst
+++ b/docs/system/devices/nvme.rst
@@ -232,7 +232,7 @@ parameters:
Set the number of Reclaim Groups.
``fdp.nruh`` (default: ``0``)
- Set the number of Reclaim Unit Handles. This is a mandatory paramater and
+ Set the number of Reclaim Unit Handles. This is a mandatory parameter and
must be non-zero.
``fdp.runs`` (default: ``96M``)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index 8b7fd9e9e5..4dd5a71fb7 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -863,7 +863,7 @@ ssize_t load_image_gzipped(const char *filename, hwaddr
addr, uint64_t max_sz)
/*
* The Linux header magic number for a EFI PE/COFF
- * image targetting an unspecified architecture.
+ * image targeting an unspecified architecture.
*/
#define EFI_PE_LINUX_MAGIC"\xcd\x23\x82\x81"
@@ -1492,7 +1492,7 @@ RomGap rom_find_largest_gap_between(hwaddr base, size_t
size)
if (rom->mr || rom->fw_file) {
continue;
}
-/* ignore anything finishing bellow base */
+/* ignore anything finishing below base */
if (rom->addr + rom->romsize <= base) {
continue;
}
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 7f5c11a0cc..68284428f8 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -942,7 +942,7 @@ struct MemoryListener {
*
* @listener: The #MemoryListener.
* @last_stage: The last stage to synchronize the log during migration.
- * The caller should gurantee that the synchronization with true for
+ * The caller should guarantee that the synchronization with true for
* @last_stage is triggered for once after all VCPUs have been stopped.
*/
void (*log_sync_global)(MemoryListener *listener, bool last_stage);
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 09200d71b8..ee853dcfcb 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -77,7 +77,7 @@ static int tight_send_framebuffer_update(VncState *vs, int x,
int y,
#ifdef CONFIG_VNC_JPEG
static const struct {
-double jpeg_freq_min; /* Don't send JPEG if the freq is bellow */
+double jpeg_freq_min; /* Don't send JPEG if the freq is below */
double jpeg_freq_threshold; /* Always send JPEG if the freq is above */
int jpeg_idx; /* Allow indexed JPEG */
int jpeg_full; /* Allow full color JPEG */
--
2.39.2
Re: [PATCH] Fix some typos in documentation and comments
On Sat, 29 Oct 2022 at 13:27, Stefan Weil via wrote: > > Most of them were found and fixed using codespell. > > Signed-off-by: Stefan Weil > --- Aside from Peter's comments: Reviewed-by: Stefan Hajnoczi
Re: [PATCH] Fix some typos in documentation and comments
On Sat, 29 Oct 2022 at 18:25, Stefan Weil wrote: > > Most of them were found and fixed using codespell. > > Signed-off-by: Stefan Weil > --- > > My focus was fixing typos which are relevant for the generated documentation. > > codespell finds many more typos in source code, and adding it to the > continuous > integration checks looks more and more like a good idea. > > Stefan > > > docs/devel/qapi-code-gen.rst| 2 +- > docs/devel/testing.rst | 2 +- > docs/system/arm/cpu-features.rst| 2 +- > docs/system/loongarch/loongson3.rst | 2 +- > docs/tools/virtiofsd.rst| 2 +- > include/exec/memory.h | 2 +- > qapi/qom.json | 2 +- > qemu-options.hx | 8 > qga/qapi-schema.json| 2 +- > tests/qtest/libqtest.h | 2 +- > 10 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst > index cd9b544376..c4c04bf755 100644 > --- a/docs/devel/qapi-code-gen.rst > +++ b/docs/devel/qapi-code-gen.rst > @@ -1313,7 +1313,7 @@ Removing "unreachable" stuff like events that can't be > triggered > anymore, optional return or event data members that can't be sent > anymore, and return or event data member (enumeration) values that > can't be sent anymore makes no difference to clients, except for > -introspection. The latter can conceivably confuse clients, so tread > +introspection. The latter can conceivably confuse clients, so treat > carefully. No, the current text is correct: "tread carefully" means "be cautious". > --- a/docs/system/loongarch/loongson3.rst > +++ b/docs/system/loongarch/loongson3.rst > @@ -41,7 +41,7 @@ can be accessed by following steps. > >$ qemu-system-loongarch64 -machine virt -m 4G -cpu la464-loongarch-cpu \ >-smp 1 -bios QEMU_EFI.fd -kernel vmlinuz.efi -initrd initrd.img \ > - -append "root=/dev/ram rdinit=/sbin/init consol e=ttyS0,115200" \ > + -append "root=/dev/ram rdinit=/sbin/init console e=ttyS0,115200" \ >--nographic This is an error, but the fix is wrong -- the space between 'l' and 'e' should just be deleted. > @@ -5248,7 +5248,7 @@ SRST > read the colo-compare git log. > > ``-object cryptodev-backend-builtin,id=id[,queues=queues]`` > -Creates a cryptodev backend which executes crypto opreation from > +Creates a cryptodev backend which executes crypto operation from Should be "operations" > the QEMU cipher APIS. The id parameter is a unique ID that will This should be "APIs". The other changes in the patch look good. thanks -- PMM
[PATCH] Fix some typos in documentation and comments
Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- My focus was fixing typos which are relevant for the generated documentation. codespell finds many more typos in source code, and adding it to the continuous integration checks looks more and more like a good idea. Stefan docs/devel/qapi-code-gen.rst| 2 +- docs/devel/testing.rst | 2 +- docs/system/arm/cpu-features.rst| 2 +- docs/system/loongarch/loongson3.rst | 2 +- docs/tools/virtiofsd.rst| 2 +- include/exec/memory.h | 2 +- qapi/qom.json | 2 +- qemu-options.hx | 8 qga/qapi-schema.json| 2 +- tests/qtest/libqtest.h | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index cd9b544376..c4c04bf755 100644 --- a/docs/devel/qapi-code-gen.rst +++ b/docs/devel/qapi-code-gen.rst @@ -1313,7 +1313,7 @@ Removing "unreachable" stuff like events that can't be triggered anymore, optional return or event data members that can't be sent anymore, and return or event data member (enumeration) values that can't be sent anymore makes no difference to clients, except for -introspection. The latter can conceivably confuse clients, so tread +introspection. The latter can conceivably confuse clients, so treat carefully. Incompatible changes include removing return and event data members. diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index fbb98faabe..e10c47b5a7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -99,7 +99,7 @@ successfully on various hosts. The following list shows some best practices: * If your test cases uses the blkdebug feature, use relative path to pass the config and image file paths in the command line as Windows absolute path contains the delimiter ":" which will confuse the blkdebug parser. -* Use double quotes in your extra QEMU commmand line in your test cases +* Use double quotes in your extra QEMU command line in your test cases instead of single quotes, as Windows does not drop single quotes when passing the command line to QEMU. * Windows opens a file in text mode by default, while a POSIX compliant diff --git a/docs/system/arm/cpu-features.rst b/docs/system/arm/cpu-features.rst index c2c01ec7d2..00c444042f 100644 --- a/docs/system/arm/cpu-features.rst +++ b/docs/system/arm/cpu-features.rst @@ -433,7 +433,7 @@ additional constraints on the set of vector lengths supported by SME. SME User-mode Default Vector Length Property -For qemu-aarch64, the cpu propery ``sme-default-vector-length=N`` is +For qemu-aarch64, the cpu property ``sme-default-vector-length=N`` is defined to mirror the Linux kernel parameter file ``/proc/sys/abi/sme_default_vector_length``. The default length, ``N``, is in units of bytes and must be between 16 and 8192. diff --git a/docs/system/loongarch/loongson3.rst b/docs/system/loongarch/loongson3.rst index 1bdab44e27..68113b6f5e 100644 --- a/docs/system/loongarch/loongson3.rst +++ b/docs/system/loongarch/loongson3.rst @@ -41,7 +41,7 @@ can be accessed by following steps. $ qemu-system-loongarch64 -machine virt -m 4G -cpu la464-loongarch-cpu \ -smp 1 -bios QEMU_EFI.fd -kernel vmlinuz.efi -initrd initrd.img \ - -append "root=/dev/ram rdinit=/sbin/init consol e=ttyS0,115200" \ + -append "root=/dev/ram rdinit=/sbin/init console e=ttyS0,115200" \ --nographic Note: The running speed may be a little slow, as the performance of our diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst index 5f5ac9dd56..995a754a7b 100644 --- a/docs/tools/virtiofsd.rst +++ b/docs/tools/virtiofsd.rst @@ -232,7 +232,7 @@ e.g.: ``:ok:server::security.:`` - will pass 'securty.' xattr's in listxattr from the server + will pass 'security.' xattr's in listxattr from the server and ignore following rules. ``:ok:all:::`` diff --git a/include/exec/memory.h b/include/exec/memory.h index bfb1de8eea..a751c111bd 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1970,7 +1970,7 @@ void memory_region_clear_dirty_bitmap(MemoryRegion *mr, hwaddr start, * querying the same page multiple times, which is especially useful for * display updates where the scanlines often are not page aligned. * - * The dirty bitmap region which gets copyed into the snapshot (and + * The dirty bitmap region which gets copied into the snapshot (and * cleared afterwards) can be larger than requested. The boundaries * are rounded up/down so complete bitmap longs (covering 64 pages on * 64bit hosts) can be copied over into the bitmap snapshot. Which diff --git a/qapi/qom.json b/qapi/qom.json index 80dd419b39..216b56a4e6 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -586,7 +586,7 @@ # # @size: size of the memory region in bytes # -#
