Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-03 Thread Peter Maydell
On Fri, 3 Jul 2020 at 17:38, Michele Denber wrote: > > Oops, I hit Send before I was done. I tried the Haiku patch: > > diff --git a/util/Makefile.objs b/util/Makefile.objs > index cc5e37177a..faebc13fac 100644 > --- a/util/Makefile.objs > +++ b/util/Makefile.objs > @@ -39,7 +39,7 @@ util-obj-y

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-03 Thread Michele Denber
Oops, I hit Send before I was done. I tried the Haiku patch: diff --git a/util/Makefile.objs b/util/Makefile.objs index cc5e37177a..faebc13fac 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@ -39,7 +39,7 @@ util-obj-y += qsp.o util-obj-y += range.o util-obj-y += stats64.o

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-03 Thread Michele Denber
On 07/03/20 01:11, Thomas Huth wrote: Did you have a local modification to that file? Oops yes, I had changed the line static int openpty(int *amaster, int *aslave, char *name, struct termios *termp, struct winsize *winp) to int openpty(int *amaster, int *aslave, char

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Thomas Huth
On 02/07/2020 23.33, Michele Denber wrote: On 07/02/20 13:34, Thomas Huth wrote: That's just the context, cut at three lines after the last change. Simply try to apply the patch with "patch -p1 -i ..." or "git am" in a separate git branch if you're using git. It should hopefully apply

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Michele Denber
On 07/02/20 13:34, Thomas Huth wrote: That's just the context, cut at three lines after the last change. Simply try to apply the patch with "patch -p1 -i ..." or "git am" in a separate git branch if you're using git. It should hopefully apply cleanly. Looks like it partly worked:

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Thomas Huth
On 02/07/2020 16.46, Daniel P. Berrangé wrote: On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote: Recent versions of Solaris (v11.4) now feature an openpty() function, too, causing a build failure since we ship our own implementation of openpty() for Solaris in util/qemu-openpty.c so

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Thomas Huth
On 02/07/2020 18.13, Michele Denber wrote: On 07/02/20 10:39, Thomas Huth wrote: Recent versions of Solaris (v11.4) now feature an openpty() function, too, causing a build failure since we ship our own implementation of openpty() for Solaris in util/qemu-openpty.c so far. Since there are now

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Michele Denber
On 07/02/20 10:39, Thomas Huth wrote: Recent versions of Solaris (v11.4) now feature an openpty() function, too, causing a build failure since we ship our own implementation of openpty() for Solaris in util/qemu-openpty.c so far. Since there are now both variants available in the wild, with

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Michele Denber
On 07/02/20 10:46, Daniel P. Berrangé wrote: On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote: Recent versions of Solaris (v11.4) now feature an openpty() function, too, causing a build failure since we ship our own implementation of openpty() for Solaris in util/qemu-openpty.c so

Re: [PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Daniel P . Berrangé
On Thu, Jul 02, 2020 at 04:39:55PM +0200, Thomas Huth wrote: > Recent versions of Solaris (v11.4) now feature an openpty() function, > too, causing a build failure since we ship our own implementation of > openpty() for Solaris in util/qemu-openpty.c so far. Since there are > now both variants

[PATCH] configure / util: Auto-detect the availability of openpty()

2020-07-02 Thread Thomas Huth
Recent versions of Solaris (v11.4) now feature an openpty() function, too, causing a build failure since we ship our own implementation of openpty() for Solaris in util/qemu-openpty.c so far. Since there are now both variants available in the wild, with and without this function, let's introduce a