Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2023-02-07 Thread Simon Glass
Hi, On Fri, 5 Nov 2021 at 09:51, François Ozog wrote: > > Hi, > > On Wed, 3 Nov 2021 at 14:17, François Ozog wrote: >> >> Hi, >> >> Thanks Alex to patch me in. >> >> I'd like to present another perspective on the motivation as I can't really >> comment on the actual "how". >> >> On real Arm

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-11-05 Thread François Ozog
Hi, On Wed, 3 Nov 2021 at 14:17, François Ozog wrote: > Hi, > > Thanks Alex to patch me in. > > I'd like to present another perspective on the motivation as I can't > really comment on the actual "how". > > On real Arm boards, firmware is often assembled into a FIP. > That FIP can contain quite

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-11-03 Thread François Ozog
Hi, Thanks Alex to patch me in. I'd like to present another perspective on the motivation as I can't really comment on the actual "how". On real Arm boards, firmware is often assembled into a FIP. That FIP can contain quite a good deal of things, including an NT_FW_CONFIG,

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-11-03 Thread Alex Bennée
Peter Maydell writes: > On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: >> On Mon, 27 Sept 2021 at 02:48, Peter Maydell >> wrote: >> > So what is missing in the QEMU-provided DTB that it needs? >> >> Quite a lot. Here are some examples: >> >> U-Boot has limited pre-relocation memory so

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-29 Thread Andrew Jones
On Wed, Sep 29, 2021 at 09:09:59AM -0600, Simon Glass wrote: > Hi Peter, > > On Wed, 29 Sept 2021 at 03:10, Peter Maydell wrote: > > > > On Wed, 29 Sept 2021 at 04:01, Simon Glass wrote: > > > On Tue, 28 Sept 2021 at 03:21, Peter Maydell > > > wrote: > > > > So what *is* this patch doing? The

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-29 Thread Simon Glass
Hi Peter, On Wed, 29 Sept 2021 at 03:10, Peter Maydell wrote: > > On Wed, 29 Sept 2021 at 04:01, Simon Glass wrote: > > On Tue, 28 Sept 2021 at 03:21, Peter Maydell > > wrote: > > > So what *is* this patch doing? The subject says "Allow additions to > > > the generated device tree", and the

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-29 Thread Peter Maydell
On Wed, 29 Sept 2021 at 04:01, Simon Glass wrote: > On Tue, 28 Sept 2021 at 03:21, Peter Maydell wrote: > > So what *is* this patch doing? The subject says "Allow additions to > > the generated device tree", and the patch adds an option to > > "Merge a device tree binary (dtb) file into the

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-28 Thread Simon Glass
Hi Peter, On Tue, 28 Sept 2021 at 03:21, Peter Maydell wrote: > > On Mon, 27 Sept 2021 at 21:12, Simon Glass wrote: > > I think you are misunderstanding my patch and that may be the problem here. > > > > Where QEMU is provided with a dtb (-dtb) it uses that and passes it > > on. This is

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-28 Thread Peter Maydell
On Mon, 27 Sept 2021 at 21:12, Simon Glass wrote: > I think you are misunderstanding my patch and that may be the problem here. > > Where QEMU is provided with a dtb (-dtb) it uses that and passes it > on. This is absolutely fine and I have tested that this works well > with U-Boot. No issues. >

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Simon Glass
Hi Peter, On Mon, 27 Sept 2021 at 10:50, Peter Maydell wrote: > > On Mon, 27 Sept 2021 at 17:04, Simon Glass wrote: > > On Mon, 27 Sept 2021 at 09:46, Peter Maydell > > wrote: > > > > My take is that this is u-boot doing weird custom things with > > > the DTB that aren't "describe the

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 17:04, Simon Glass wrote: > On Mon, 27 Sept 2021 at 09:46, Peter Maydell wrote: > > My take is that this is u-boot doing weird custom things with > > the DTB that aren't "describe the hardware". You should be able > > to boot u-boot by putting those custom DTB extra

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Simon Glass
Hi Peter, On Mon, 27 Sept 2021 at 09:46, Peter Maydell wrote: > > On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: > > On Mon, 27 Sept 2021 at 02:48, Peter Maydell > > wrote: > > > So what is missing in the QEMU-provided DTB that it needs? > > > > Quite a lot. Here are some examples: > > > >

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: > On Mon, 27 Sept 2021 at 02:48, Peter Maydell wrote: > > So what is missing in the QEMU-provided DTB that it needs? > > Quite a lot. Here are some examples: > > U-Boot has limited pre-relocation memory so tries to avoid > binding/probing devices

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Simon Glass
Hi Peter, On Mon, 27 Sept 2021 at 02:48, Peter Maydell wrote: > > On Sun, 26 Sept 2021 at 19:55, Simon Glass wrote: > > In the case of U-Boot at least, it uses the devicetree for > > configuration (it is a boot loader, so there is no user space to > > provide configuration). So the current

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Sun, 26 Sept 2021 at 19:55, Simon Glass wrote: > In the case of U-Boot at least, it uses the devicetree for > configuration (it is a boot loader, so there is no user space to > provide configuration). So the current setup is not sufficient to boot > it correctly in all cases. On the other

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-26 Thread Simon Glass
Hi Peter, On Sun, 26 Sept 2021 at 12:47, Peter Maydell wrote: > > On Sun, 26 Sept 2021 at 19:34, Simon Glass wrote: > > > > At present qemu creates a device tree automatically with the 'virt' generic > > virtual platform. This is very convenient in most cases but there is not > > much control

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-26 Thread Peter Maydell
On Sun, 26 Sept 2021 at 19:34, Simon Glass wrote: > > At present qemu creates a device tree automatically with the 'virt' generic > virtual platform. This is very convenient in most cases but there is not > much control over what is generated. > > Add a way to provide a device tree binary file

[PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-26 Thread Simon Glass
At present qemu creates a device tree automatically with the 'virt' generic virtual platform. This is very convenient in most cases but there is not much control over what is generated. Add a way to provide a device tree binary file with additional properties to add before booting. This provides