Re: [PATCH] hw/arm/virt: support both pl011 and 16550 uart

2023-03-23 Thread Peter Maydell
On Wed, 22 Mar 2023 at 23:27, Patrick Venture wrote: > > From: Shu-Chun Weng > > Select uart for virt machine from pl011 and ns16550a with > -M virt,uart={pl011|ns16550a}. Firm "no". The PL011 is a perfectly good UART widely supported by guest OSes, and there is no reason why we should want to

Re: [PATCH] hw/arm/virt: support both pl011 and 16550 uart

2023-03-23 Thread Philippe Mathieu-Daudé
On 23/3/23 00:27, Patrick Venture wrote: From: Shu-Chun Weng Select uart for virt machine from pl011 and ns16550a with -M virt,uart={pl011|ns16550a}. This commit description is missing the "why" we want this change. In which case the pl011 isn't enough or we don't want it? Signed-off-by:

[PATCH] hw/arm/virt: support both pl011 and 16550 uart

2023-03-22 Thread Patrick Venture
From: Shu-Chun Weng Select uart for virt machine from pl011 and ns16550a with -M virt,uart={pl011|ns16550a}. Signed-off-by: Shu-Chun Weng Signed-off-by: Patrick Venture --- hw/arm/virt.c | 85 ++- include/hw/arm/virt.h | 6 +++ 2 files