Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Francisco Iglesias 




On 2023-02-16 10:23, Philippe Mathieu-Daudé wrote:

Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
a QEMU configured using --without-default-devices, we get:

   $ qemu-system-aarch64 -M xlnx-zcu102
   qemu-system-aarch64: missing object type 'usb_dwc3'
   Abort trap: 6

Fix by adding the missing Kconfig dependency.

Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
Signed-off-by: Philippe Mathieu-Daudé 


Reviewed-by: Francisco Iglesias 


---
  hw/arm/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 2d157de9b8..b5aed4aff5 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
  select XLNX_CSU_DMA
  select XLNX_ZYNQMP
  select XLNX_ZDMA
+select USB_DWC3
  
  config XLNX_VERSAL

  bool

Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Peter Maydell 
On Thu, 16 Feb 2023 at 09:27, Philippe Mathieu-Daudé  wrote:
>
> Oops I meant this as subject:
> "hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency"
>
> On 16/2/23 10:23, Philippe Mathieu-Daudé wrote:
> > Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
> > a QEMU configured using --without-default-devices, we get:
> >
> >$ qemu-system-aarch64 -M xlnx-zcu102
> >qemu-system-aarch64: missing object type 'usb_dwc3'
> >Abort trap: 6
> >
> > Fix by adding the missing Kconfig dependency.
> >
> > Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
> > Signed-off-by: Philippe Mathieu-Daudé 



Applied to target-arm.next with the subject line fixed, thanks.

-- PMM

Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Philippe Mathieu-Daudé 

Oops I meant this as subject:
"hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency"

On 16/2/23 10:23, Philippe Mathieu-Daudé wrote:

Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
a QEMU configured using --without-default-devices, we get:

   $ qemu-system-aarch64 -M xlnx-zcu102
   qemu-system-aarch64: missing object type 'usb_dwc3'
   Abort trap: 6

Fix by adding the missing Kconfig dependency.

Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
Signed-off-by: Philippe Mathieu-Daudé 
---
  hw/arm/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 2d157de9b8..b5aed4aff5 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
  select XLNX_CSU_DMA
  select XLNX_ZYNQMP
  select XLNX_ZDMA
+select USB_DWC3
  
  config XLNX_VERSAL

  bool

[PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Philippe Mathieu-Daudé 
Since commit acc0b8b05a when running the ZynqMP ZCU102 board with
a QEMU configured using --without-default-devices, we get:

  $ qemu-system-aarch64 -M xlnx-zcu102
  qemu-system-aarch64: missing object type 'usb_dwc3'
  Abort trap: 6

Fix by adding the missing Kconfig dependency.

Fixes: acc0b8b05a ("hw/arm/xlnx-zynqmp: Connect ZynqMP's USB controllers")
Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 2d157de9b8..b5aed4aff5 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -389,6 +389,7 @@ config XLNX_ZYNQMP_ARM
 select XLNX_CSU_DMA
 select XLNX_ZYNQMP
 select XLNX_ZDMA
+select USB_DWC3
 
 config XLNX_VERSAL
 bool
-- 
2.38.1