Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-14 Thread manish.mishra
Thanks Peter On 14/11/22 10:21 pm, Peter Xu wrote: Manish, On Thu, Nov 03, 2022 at 11:47:51PM +0530, manish.mishra wrote: Yes, but if we try to read early on main channel with tls enabled case it is an issue. Sorry i may not have put above comment cleary. I will try to put scenario step

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-14 Thread Peter Xu
Manish, On Thu, Nov 03, 2022 at 11:47:51PM +0530, manish.mishra wrote: > Yes, but if we try to read early on main channel with tls enabled case it is > an issue. Sorry i may not have put above comment cleary. I will try to put > scenario step wise. > 1. main channel is created and tls handshake

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 03/11/22 11:47 pm, manish.mishra wrote: On 03/11/22 11:27 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 11:06:23PM +0530, manish.mishra wrote: On 03/11/22 10:57 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: On 03/11/22 2:59 pm,

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 03/11/22 11:47 pm, manish.mishra wrote: On 03/11/22 11:27 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 11:06:23PM +0530, manish.mishra wrote: On 03/11/22 10:57 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: On 03/11/22 2:59 pm,

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 03/11/22 11:27 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 11:06:23PM +0530, manish.mishra wrote: On 03/11/22 10:57 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: On 03/11/22 2:59 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread Daniel P . Berrangé
On Thu, Nov 03, 2022 at 11:06:23PM +0530, manish.mishra wrote: > > On 03/11/22 10:57 pm, Daniel P. Berrangé wrote: > > On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: > > > On 03/11/22 2:59 pm, Daniel P. Berrangé wrote: > > > > On Thu, Nov 03, 2022 at 02:50:25PM +0530,

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 03/11/22 10:57 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: On 03/11/22 2:59 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote: On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread Daniel P . Berrangé
On Thu, Nov 03, 2022 at 10:04:54PM +0530, manish.mishra wrote: > > On 03/11/22 2:59 pm, Daniel P. Berrangé wrote: > > On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote: > > > On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 03/11/22 2:59 pm, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote: On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread Daniel P . Berrangé
On Thu, Nov 03, 2022 at 02:50:25PM +0530, manish.mishra wrote: > > On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: > > > On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-03 Thread manish.mishra
On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread Daniel P . Berrangé
On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: > > On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: > > > Current logic assumes that channel connections on the destination side are > > > always established in the

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread manish.mishra
On 01/11/22 9:15 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 09:10:14PM +0530, manish.mishra wrote: On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread Daniel P . Berrangé
On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: > Current logic assumes that channel connections on the destination side are > always established in the same order as the source and the first one will > always be the default channel followed by the multifid or post-copy > preemption

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread manish.mishra
On 01/11/22 8:21 pm, Daniel P. Berrangé wrote: On Tue, Nov 01, 2022 at 02:30:29PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the default channel

Re: [PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread manish.mishra
Sorry for late patch on this. I mentioned i will send it last week itself, but later reliased it was festival week in India, so was mostly holidays. Thanks Manish Mishra On 01/11/22 8:00 pm, manish.mishra wrote: Current logic assumes that channel connections on the destination side are

[PATCH] migration: check magic value for deciding the mapping of channels

2022-11-01 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the default channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a