Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-16 Thread Stefan Hajnoczi
On Tue, Mar 10, 2020 at 12:47:49PM +0100, Christian Ehrhardt wrote: > On Tue, Mar 10, 2020 at 10:39 AM Stefan Hajnoczi wrote: > > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > And finally this has to be considered an "offer" by qemu to the packagers > to fix a real field

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Daniel P . Berrangé
On Fri, Mar 13, 2020 at 08:45:21AM +0100, Paolo Bonzini wrote: > On 13/03/20 08:34, Michael Tokarev wrote: > >> The use of /var/run makes me a little uneasy. I guess it's related to > >> wanting to uninstall the old package so the .so in their original > >> location cannot be used (even if they

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Paolo Bonzini
On 13/03/20 08:34, Michael Tokarev wrote: >> The use of /var/run makes me a little uneasy. I guess it's related to >> wanting to uninstall the old package so the .so in their original >> location cannot be used (even if they had a versioned path)? > > BTW, this is /run nowadays, not /var/run, as

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-13 Thread Michael Tokarev
10.03.2020 12:39, Stefan Hajnoczi wrote: > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: >> On upgrades the old .so files usually are replaced. But on the other >> hand since a qemu process represents a guest instance it is usually kept >> around. >> >> That makes late

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-10 Thread Christian Ehrhardt
On Tue, Mar 10, 2020 at 1:10 PM Daniel P. Berrangé wrote: > On Tue, Mar 10, 2020 at 09:39:10AM +, Stefan Hajnoczi wrote: > > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > > > On upgrades the old .so files usually are replaced. But on the other > > > hand since a qemu

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-10 Thread Daniel P . Berrangé
On Tue, Mar 10, 2020 at 09:39:10AM +, Stefan Hajnoczi wrote: > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > > On upgrades the old .so files usually are replaced. But on the other > > hand since a qemu process represents a guest instance it is usually kept > > around. >

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-10 Thread Christian Ehrhardt
On Tue, Mar 10, 2020 at 10:39 AM Stefan Hajnoczi wrote: > On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > > On upgrades the old .so files usually are replaced. But on the other > > hand since a qemu process represents a guest instance it is usually kept > > around. > > > >

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-10 Thread Stefan Hajnoczi
On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > On upgrades the old .so files usually are replaced. But on the other > hand since a qemu process represents a guest instance it is usually kept > around. > > That makes late addition of dynamic features e.g. 'hot-attach of a

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-09 Thread Christian Ehrhardt
On Fri, Mar 6, 2020 at 3:42 PM wrote: > Patchew URL: > https://patchew.org/QEMU/20200306132648.27577-1-christian.ehrha...@canonical.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200306132648.27577-1-christian.ehrha...@canonical.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-06 Thread Christian Ehrhardt
On Fri, Mar 6, 2020 at 11:54 AM Stefan Hajnoczi wrote: > On Wed, Mar 04, 2020 at 10:39:46AM +0100, Christian Ehrhardt wrote: > > Please start a new email thread. Patches sent as replies to existing > email threads are easily missed by humans and tooling also doesn't > recognize them. > Sure,

[PATCH] modules: load modules from versioned /var/run dir

2020-03-06 Thread Christian Ehrhardt
On upgrades the old .so files usually are replaced. But on the other hand since a qemu process represents a guest instance it is usually kept around. That makes late addition of dynamic features e.g. 'hot-attach of a ceph disk' fail by trying to load a new version of e.f. block-rbd.so into an old

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-06 Thread Stefan Hajnoczi
On Wed, Mar 04, 2020 at 10:39:46AM +0100, Christian Ehrhardt wrote: Please start a new email thread. Patches sent as replies to existing email threads are easily missed by humans and tooling also doesn't recognize them. signature.asc Description: PGP signature

[PATCH] modules: load modules from versioned /var/run dir

2020-03-04 Thread Christian Ehrhardt
On upgrades the old .so files usually are replaced. But on the other hand since a qemu process represents a guest instance it is usually kept around. That makes late addition of dynamic features e.g. 'hot-attach of a ceph disk' fail by trying to load a new version of e.f. block-rbd.so into an old