Re: [PATCH] ninjatool: quote dollars in variables

2020-08-28 Thread Laurent Vivier
Le 27/08/2020 à 11:14, Paolo Bonzini a écrit : > ... and actually it's fixed in 0.55.1. We can therefore just update the > submodule and declare 0.55.1 the minimum required version for QEMU. > Updating the meson submodule to 0.55.1 has fixed the problem for me. Thanks, Laurent

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Paolo Bonzini
Il gio 27 ago 2020, 12:08 Peter Maydell ha scritto: > On Thu, 27 Aug 2020 at 10:20, Paolo Bonzini wrote: > > > > ... and actually it's fixed in 0.55.1. We can therefore just update the > submodule and declare 0.55.1 the minimum required version for QEMU. > > Oh, I meant to ask -- if 0.56 is the

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Peter Maydell
On Thu, 27 Aug 2020 at 10:20, Paolo Bonzini wrote: > > ... and actually it's fixed in 0.55.1. We can therefore just update the > submodule and declare 0.55.1 the minimum required version for QEMU. Oh, I meant to ask -- if 0.56 is the one that gets rid of the warnings about unstable-keyval

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Paolo Bonzini
... and actually it's fixed in 0.55.1. We can therefore just update the submodule and declare 0.55.1 the minimum required version for QEMU. Paolo Il gio 27 ago 2020, 11:10 Paolo Bonzini ha scritto: > Found; https://github.com/mesonbuild/Meson/issues/5191. > > (With the fix there's no rpath at

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Paolo Bonzini
Found; https://github.com/mesonbuild/Meson/issues/5191. (With the fix there's no rpath at all in the QEMU build process). Let's ask for a backport to 0.55.2. Paolo Il gio 27 ago 2020, 10:22 Paolo Bonzini ha scritto: > > > Il gio 27 ago 2020, 09:33 Laurent Vivier ha scritto: > >> This

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Paolo Bonzini
Il gio 27 ago 2020, 09:33 Laurent Vivier ha scritto: > This actually fixes the '-Wl,-rpath,$ORIGIN/', but doesn't fix the crash > with statically linked binaries. > I will try to reproduce when I am back; it works for Peter so there must be something different in the setup. In any case, if

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-27 Thread Laurent Vivier
Le 26/08/2020 à 21:01, Paolo Bonzini a écrit : > Otherwise, dollars (such as in the special $ORIGIN rpath) are > eaten by Make. > > Reported-by: Laurent Vivier > Signed-off-by: Paolo Bonzini > --- > scripts/ninjatool.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Alexander Bulekov
On 200827 0613, Paolo Bonzini wrote: > Il mer 26 ago 2020, 21:34 Peter Maydell ha > scritto: > > > On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > > > > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > > > eaten by Make. > > > > Incidentally, why are we using rpath

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Paolo Bonzini
Il mer 26 ago 2020, 21:34 Peter Maydell ha scritto: > On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > > eaten by Make. > > Incidentally, why are we using rpath anyway? I'm pretty > sure the old build system didn't need

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Peter Maydell
On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > eaten by Make. Incidentally, why are we using rpath anyway? I'm pretty sure the old build system didn't need it, and it's one of those features I have mentally filed away under

[PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Paolo Bonzini
Otherwise, dollars (such as in the special $ORIGIN rpath) are eaten by Make. Reported-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- scripts/ninjatool.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/ninjatool.py b/scripts/ninjatool.py index