Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-09-01 Thread Jason J. Herne
On 8/27/20 6:07 AM, Thomas Huth wrote: On 07/02/2020 15.02, Jason J. Herne wrote: On 2/7/20 6:28 AM, Christian Borntraeger wrote: Jason, can you run objdump -Sdr on jump2ipl.o on a broken variant? To keep the volume lower, I've only pasted the output that I think you're interested in. If

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-08-27 Thread Thomas Huth
On 07/02/2020 15.02, Jason J. Herne wrote: > On 2/7/20 6:28 AM, Christian Borntraeger wrote: >> Jason, >> >> can you run objdump -Sdr on jump2ipl.o on a broken variant? >> >> > To keep the volume lower, I've only pasted the output that I think > you're interested in. If you want to see the entire

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Christian Borntraeger
On 25.02.20 16:00, Christian Borntraeger wrote: > > > On 25.02.20 13:58, Jason J. Herne wrote: >> On 2/25/20 6:13 AM, Christian Borntraeger wrote: >>> >>> >>> On 25.02.20 11:23, Jason J. Herne wrote: On 2/13/20 1:24 PM, Christian Borntraeger wrote: ... >>> diff --git

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Christian Borntraeger
On 25.02.20 13:58, Jason J. Herne wrote: > On 2/25/20 6:13 AM, Christian Borntraeger wrote: >> >> >> On 25.02.20 11:23, Jason J. Herne wrote: >>> On 2/13/20 1:24 PM, Christian Borntraeger wrote: >>> ... >> diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c >> index

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Jason J. Herne
On 2/25/20 6:13 AM, Christian Borntraeger wrote: On 25.02.20 11:23, Jason J. Herne wrote: On 2/13/20 1:24 PM, Christian Borntraeger wrote: ... diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c index da13c43cc0..8839226803 100644 --- a/pc-bios/s390-ccw/jump2ipl.c +++

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Christian Borntraeger
On 25.02.20 11:23, Jason J. Herne wrote: > On 2/13/20 1:24 PM, Christian Borntraeger wrote: > ... diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c index da13c43cc0..8839226803 100644 --- a/pc-bios/s390-ccw/jump2ipl.c +++ b/pc-bios/s390-ccw/jump2ipl.c

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Jason J. Herne
On 2/13/20 1:24 PM, Christian Borntraeger wrote: ... diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c index da13c43cc0..8839226803 100644 --- a/pc-bios/s390-ccw/jump2ipl.c +++ b/pc-bios/s390-ccw/jump2ipl.c @@ -18,6 +18,7 @@   typedef struct ResetInfo {   uint64_t

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-13 Thread Christian Borntraeger
On 13.02.20 19:02, Jason J. Herne wrote: > On 2/6/20 5:09 AM, Christian Borntraeger wrote: >> >> >> On 05.02.20 19:21, Jason J. Herne wrote: >>> This fixes vfio-ccw when booting non-Linux operating systems. Without this >>> struct being packed, a few extra bytes of low core memory get

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-13 Thread Jason J. Herne
On 2/6/20 5:09 AM, Christian Borntraeger wrote: On 05.02.20 19:21, Jason J. Herne wrote: This fixes vfio-ccw when booting non-Linux operating systems. Without this struct being packed, a few extra bytes of low core memory get overwritten when we assign a value to memory address 0 in

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-07 Thread Jason J. Herne
On 2/7/20 6:28 AM, Christian Borntraeger wrote: Jason, can you run objdump -Sdr on jump2ipl.o on a broken variant? To keep the volume lower, I've only pasted the output that I think you're interested in. If you want to see the entire thing just let me know. static void jump_to_IPL_2(void)

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-07 Thread Christian Borntraeger
Jason, can you run objdump -Sdr on jump2ipl.o on a broken variant? On 06.02.20 12:00, Thomas Huth wrote: > On 06/02/2020 11.09, Christian Borntraeger wrote: >> >> >> On 05.02.20 19:21, Jason J. Herne wrote: >>> This fixes vfio-ccw when booting non-Linux operating systems. Without this >>>

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Thomas Huth
On 06/02/2020 11.09, Christian Borntraeger wrote: > > > On 05.02.20 19:21, Jason J. Herne wrote: >> This fixes vfio-ccw when booting non-Linux operating systems. Without this >> struct being packed, a few extra bytes of low core memory get overwritten >> when >> we assign a value to memory

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Christian Borntraeger
On 05.02.20 19:21, Jason J. Herne wrote: > This fixes vfio-ccw when booting non-Linux operating systems. Without this > struct being packed, a few extra bytes of low core memory get overwritten when > we assign a value to memory address 0 in jump_to_IPL_2. This is enough to > cause some

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Cornelia Huck
On Wed, 5 Feb 2020 13:21:26 -0500 "Jason J. Herne" wrote: > This fixes vfio-ccw when booting non-Linux operating systems. Without this > struct being packed, a few extra bytes of low core memory get overwritten when > we assign a value to memory address 0 in jump_to_IPL_2. This is enough to >

[PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-05 Thread Jason J. Herne
This fixes vfio-ccw when booting non-Linux operating systems. Without this struct being packed, a few extra bytes of low core memory get overwritten when we assign a value to memory address 0 in jump_to_IPL_2. This is enough to cause some non-Linux OSes of fail when booting. The problem was