Re: [PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread Jason A. Donenfeld
On Thu, Jan 2, 2020 at 12:41 PM Laurent Vivier wrote: > > Le 02/01/2020 à 12:10, Laurent Vivier a écrit : > > Le 02/01/2020 à 11:36, Jason A. Donenfeld a écrit : > >> On Linux, calling `reboot(RB_AUTOBOOT);` will result in > >> arch/m68k/mac/misc.c's mac_reset function being called. That in turn

Re: [PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread Laurent Vivier
Le 02/01/2020 à 12:10, Laurent Vivier a écrit : > Le 02/01/2020 à 11:36, Jason A. Donenfeld a écrit : >> On Linux, calling `reboot(RB_AUTOBOOT);` will result in >> arch/m68k/mac/misc.c's mac_reset function being called. That in turn >> looks at the rombase (or uses 0x4080 is there's no

Re: [PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread Laurent Vivier
Le 02/01/2020 à 11:36, Jason A. Donenfeld a écrit : > On Linux, calling `reboot(RB_AUTOBOOT);` will result in > arch/m68k/mac/misc.c's mac_reset function being called. That in turn > looks at the rombase (or uses 0x4080 is there's no rombase), adds > 0xa, and jumps to that address. At the

Re: [PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200102103644.233370-1-ja...@zx2c4.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200102103644.233370-1-ja...@zx2c4.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] q800: implement mac rom reset function for BIOS-less mode Type: series Message-id

[PATCH] q800: implement mac rom reset function for BIOS-less mode

2020-01-02 Thread Jason A. Donenfeld
On Linux, calling `reboot(RB_AUTOBOOT);` will result in arch/m68k/mac/misc.c's mac_reset function being called. That in turn looks at the rombase (or uses 0x4080 is there's no rombase), adds 0xa, and jumps to that address. At the moment, there's nothing there, so the kernel just crashes when