Re: [PATCH] qga: fix assert regression on guest-shutdown

On Tue, Jun 9, 2020 at 1:15 PM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Jun 4, 2020 at 3:43 PM Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > >> >> >> On Thu, Jun 4, 2020 at 11:46 AM Marc-André Lureau < >> marcandre.lur...@redhat.com> wrote:

Re: [PATCH] qga: fix assert regression on guest-shutdown

On Thu, Jun 4, 2020 at 3:43 PM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Jun 4, 2020 at 11:46 AM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > >> Since commit 781f2b3d1e ("qga: process_event() simplification"), >> send_response() is called

Re: [PATCH] qga: fix assert regression on guest-shutdown

On Thu, Jun 4, 2020 at 11:46 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Since commit 781f2b3d1e ("qga: process_event() simplification"), > send_response() is called unconditionally, but will assert when "rsp" is > NULL. This may happen with QCO_NO_SUCCESS_RESP commands, such as

Re: [PATCH] qga: fix assert regression on guest-shutdown

On 6/4/20 11:44 AM, Marc-André Lureau wrote: > Since commit 781f2b3d1e ("qga: process_event() simplification"), > send_response() is called unconditionally, but will assert when "rsp" is > NULL. This may happen with QCO_NO_SUCCESS_RESP commands, such as > "guest-shutdown". > > Fixes:

[PATCH] qga: fix assert regression on guest-shutdown

Since commit 781f2b3d1e ("qga: process_event() simplification"), send_response() is called unconditionally, but will assert when "rsp" is NULL. This may happen with QCO_NO_SUCCESS_RESP commands, such as "guest-shutdown". Fixes: 781f2b3d1e5ef389b44016a897fd55e7a780bf35 Cc: Michael Roth