Re: [PATCH] qom: fix objects with improper parent type

2020-10-07 Thread Paolo Bonzini
On 06/10/20 21:20, snizovt...@gmail.com wrote: > On Tue, 2020-10-06 at 01:55 -0400, Michael S. Tsirkin wrote: >> On Tue, Sep 29, 2020 at 04:47:14PM -0700, Sergey Nizovtsev wrote: >>> Some objects accidentally inherit ObjectClass instead of Object. >>> They compile silently but may crash after

Re: [PATCH] qom: fix objects with improper parent type

2020-10-06 Thread snizovtsev
On Tue, 2020-10-06 at 01:55 -0400, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 04:47:14PM -0700, Sergey Nizovtsev wrote: > > Some objects accidentally inherit ObjectClass instead of Object. > > They compile silently but may crash after downcasting. > > > > In this patch, we introduce a

Re: [PATCH] qom: fix objects with improper parent type

2020-10-05 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 04:47:14PM -0700, Sergey Nizovtsev wrote: > Some objects accidentally inherit ObjectClass instead of Object. > They compile silently but may crash after downcasting. > > In this patch, we introduce a coccinelle script to find broken > declarations and fix them manually

Re: [PATCH] qom: fix objects with improper parent type

2020-10-05 Thread Marc-André Lureau
On Wed, Sep 30, 2020 at 3:47 AM Sergey Nizovtsev wrote: > > Some objects accidentally inherit ObjectClass instead of Object. > They compile silently but may crash after downcasting. > > In this patch, we introduce a coccinelle script to find broken > declarations and fix them manually with proper

Re: [PATCH] qom: fix objects with improper parent type

2020-10-05 Thread Igor Mammedov
On Tue, 29 Sep 2020 16:47:14 -0700 Sergey Nizovtsev wrote: > Some objects accidentally inherit ObjectClass instead of Object. > They compile silently but may crash after downcasting. > > In this patch, we introduce a coccinelle script to find broken > declarations and fix them manually with

[PATCH] qom: fix objects with improper parent type

2020-09-29 Thread Sergey Nizovtsev
Some objects accidentally inherit ObjectClass instead of Object. They compile silently but may crash after downcasting. In this patch, we introduce a coccinelle script to find broken declarations and fix them manually with proper base type. Signed-off-by: Sergey Nizovtsev ---

[PATCH] qom: fix objects with improper parent type

2020-09-29 Thread Sergey Nizovtsev
Some objects accidentally inherit ObjectClass instead of Object. They compile silently but may crash after downcasting. In this patch, we introduce a coccinelle script to find broken declarations and fix them manually with proper base type. Signed-off-by: Sergey Nizovtsev ---

[PATCH] qom: fix objects with improper parent type

2020-09-29 Thread Sergey Nizovtsev
Some objects accidentally inherit ObjectClass instead of Object. They compile silently but may crash after downcasting. In this patch, we introduce a coccinelle script to find broken declarations and fix them manually with proper base type. Signed-off-by: Sergey Nizovtsev ---