Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 5:25 PM, Alexander Bulekov wrote: > Reviewed-by: Alexander Bulekov > > If rcu.h should be explicitly included, should any of these other files > that reference the rcu but do not explicitly #include qemu/rcu.h also > get such includes? Personally I think so, yes. > > util/qht.c >

Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Alexander Bulekov
Reviewed-by: Alexander Bulekov If rcu.h should be explicitly included, should any of these other files that reference the rcu but do not explicitly #include qemu/rcu.h also get such includes? util/qht.c 166:struct rcu_head rcu; migration/savevm.c 1822:rcu_register_thread(); util/log.c

[PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Philippe Mathieu-Daudé
In commit 73c6e4013b we let vl.c use rcu_disable_atfork() which is declared in "qemu/rcu.h", but forgot to include this header. Fortunately has never been a problem since vl.c includes "exec/memory.h" which includes "qemu/rcu.h". Include the missing header now in case we split vl.c later. Fixes: