Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-04-01 Thread Vitaly Kuznetsov
"Montes, Julio" writes: >> Does you kernel have 95c5c7c77c ("KVM: nVMX: list VMX MSRs in >> KVM_GET_MSR_INDEX_LIST")? > > I was using linux 5.0.0, now I have 5.3.0 and it's working, thanks for fixing > this > Thanks for the confirmation! I don't see any good solution for kernels without

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-04-01 Thread Montes, Julio
ontes, Julio Cc: Marcelo Tosatti ; Eduardo Habkost ; Dr . David Alan Gilbert ; Richard Henderson ; Paolo Bonzini ; qemu-devel@nongnu.org Subject: Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls "Montes, Julio" writes: > Hi Vitaly > > tha

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-04-01 Thread Vitaly Kuznetsov
"Dr. David Alan Gilbert" writes: > So you would think that would tkae care of RDSEED exiting - but what > about VMCS shadowing? > SECONDARY_EXEC_SHADOW_VMCS is special, we are able to emulate it in KVM even when it is not supported by hardware, see nested_vmx_setup_ctls_msrs(): /*

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-04-01 Thread Vitaly Kuznetsov
"Montes, Julio" writes: > Hi Vitaly > > thanks for raising this, unfortunately this patch didn't work for me, I still > get the same error: > > Does you kernel have 95c5c7c77c ("KVM: nVMX: list VMX MSRs in KVM_GET_MSR_INDEX_LIST")? -- Vitaly

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
; qemu-devel@nongnu.org ; Marcelo Tosatti ; Eduardo Habkost ; Richard Henderson Subject: Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls * Montes, Julio (julio.mon...@intel.com) wrote: > Sorry for my last email, it was incomplete > > Hi Vitaly &

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Dr. David Alan Gilbert
* Montes, Julio (julio.mon...@intel.com) wrote: > Sorry for my last email, it was incomplete > > Hi Vitaly > > thanks for raising this, unfortunately this patch didn't work for me, I still > get the same error: Are you trying that on top of 5.0 or ontop of the older 4.2 world? >

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
Sent: Tuesday, March 31, 2020 10:56 AM To: Paolo Bonzini ; Vitaly Kuznetsov ; qemu-devel@nongnu.org Cc: Marcelo Tosatti ; Eduardo Habkost ; Dr . David Alan Gilbert ; Richard Henderson Subject: Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls Hi Vitaly

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
Cc: Marcelo Tosatti ; Eduardo Habkost ; Dr . David Alan Gilbert ; Richard Henderson Subject: Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls On 31/03/20 18:27, Vitaly Kuznetsov wrote: > Commit 048c95163b4 ("target/i386: work around KVM_GET_

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Paolo Bonzini
On 31/03/20 18:27, Vitaly Kuznetsov wrote: > Commit 048c95163b4 ("target/i386: work around KVM_GET_MSRS bug for > secondary execution controls") added a workaround for KVM pre-dating > commit 6defc591846d ("KVM: nVMX: include conditional controls in /dev/kvm > KVM_GET_MSRS") which wasn't setting

[PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Vitaly Kuznetsov
Commit 048c95163b4 ("target/i386: work around KVM_GET_MSRS bug for secondary execution controls") added a workaround for KVM pre-dating commit 6defc591846d ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS") which wasn't setting certain available controls. The workaround uses