Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread Joseph Myers
Testing with the glibc testsuite shows this patch needs a little more work to get correct underflow/inexact exceptions in the case where ST0 is positive and ST1/ST0 is small. I'll send a revised patch next week (I don't expect any changes in the rest of the code). -- Joseph S. Myers

Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread Joseph Myers
On Fri, 19 Jun 2020, no-re...@patchew.org wrote: > This series seems to have some coding style problems. See output below for > more information: This is the same issues as before of this patch checker not understanding hex float constants, and it not seeming particularly useful to wrap lines

Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread Joseph Myers
On Fri, 19 Jun 2020, no-re...@patchew.org wrote: > This series failed the docker-mingw@fedora build test. Please find the > testing commands and their output below. If you have Docker installed, > you can probably reproduce it locally. This is because the patch depends on my previous patch to

Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

[PATCH] target/i386: reimplement fpatan using floatx80 operations

2020-06-19 Thread Joseph Myers
The x87 fpatan emulation is currently based around conversion to double. This is inherently unsuitable for a good emulation of any floatx80 operation. Reimplement using the soft-float operations, as for other such instructions. Signed-off-by: Joseph Myers --- target/i386/fpu_helper.c