Re: [PATCH] target/s390x: Fix 32-bit shifts

2022-01-11 Thread Ilya Leoshkevich
On Tue, 2022-01-11 at 15:22 +0100, David Hildenbrand wrote: > On 10.01.22 19:59, Ilya Leoshkevich wrote: > > Both 32- and 64-bit shifts use lowest 6 address bits. The current > > code > > special-cases 32-bit shifts to use only 5 bits, which is not > > correct. > > > > I assume for 32-bit

Re: [PATCH] target/s390x: Fix 32-bit shifts

2022-01-11 Thread David Hildenbrand
On 10.01.22 19:59, Ilya Leoshkevich wrote: > Both 32- and 64-bit shifts use lowest 6 address bits. The current code > special-cases 32-bit shifts to use only 5 bits, which is not correct. > I assume for 32-bit shifts, we could only shift by 31, not by 32 or bigger. So it's impossible to zero out

[PATCH] target/s390x: Fix 32-bit shifts

2022-01-10 Thread Ilya Leoshkevich
Both 32- and 64-bit shifts use lowest 6 address bits. The current code special-cases 32-bit shifts to use only 5 bits, which is not correct. Fix by merging sh32 and sh64. Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE") Signed-off-by: Ilya Leoshkevich ---