Re: [PATCH-for-5.0 v2] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Richard Henderson
On 4/3/20 11:44 AM, Philippe Mathieu-Daudé wrote:
> Coverity reported a missing fall through comment, add it.
> 
> Fixes: e5918d7d7f0 ("target/rx: TCG translation")
> Reported-by: Coverity (CID 142 MISSING_BREAK)
> Suggested-by: Richard Henderson 
> Signed-off-by: Philippe Mathieu-Daudé 
> ---
> v2: Fixed typo 'comments -> comment'
> ---
>  target/rx/translate.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson 


r~



[PATCH-for-5.0 v2] target/rx/translate: Add missing fall through comment

2020-04-03 Thread Philippe Mathieu-Daudé
Coverity reported a missing fall through comment, add it.

Fixes: e5918d7d7f0 ("target/rx: TCG translation")
Reported-by: Coverity (CID 142 MISSING_BREAK)
Suggested-by: Richard Henderson 
Signed-off-by: Philippe Mathieu-Daudé 
---
v2: Fixed typo 'comments -> comment'
---
 target/rx/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/rx/translate.c b/target/rx/translate.c
index b3d7305f23..61e86653a4 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -2362,6 +2362,7 @@ static void rx_tr_tb_stop(DisasContextBase *dcbase, 
CPUState *cs)
 break;
 case DISAS_UPDATE:
 tcg_gen_movi_i32(cpu_pc, ctx->base.pc_next);
+/* fall through */
 case DISAS_EXIT:
 tcg_gen_exit_tb(NULL, 0);
 break;
-- 
2.21.1