Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Stefan Hajnoczi
On Wed, Aug 19, 2020 at 12:10:20PM +0200, Philippe Mathieu-Daudé wrote: > But for now I'm not sure the check has to be enforced, because I'm not > sure what we really want to do. First we need to figure out the 'bus' > component of a a MemoryRegion (where it sits), as it affects the >

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 11:14 AM, Stefan Hajnoczi wrote: > On Tue, Aug 18, 2020 at 09:56:37AM +0200, Philippe Mathieu-Daudé wrote: >> On 8/18/20 8:32 AM, Paolo Bonzini wrote: >>> On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: Add trace events to audit MemoryRegionOps field such: - are all the

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 09:56:37AM +0200, Philippe Mathieu-Daudé wrote: > On 8/18/20 8:32 AM, Paolo Bonzini wrote: > > On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: > >> Add trace events to audit MemoryRegionOps field such: > >> - are all the valid/impl fields provided? > >> - is the region a

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 8:32 AM, Paolo Bonzini wrote: > On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: >> Add trace events to audit MemoryRegionOps field such: >> - are all the valid/impl fields provided? >> - is the region a power of two? >> >> These cases are accepted, but it is interesting to list them.

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-18 Thread Paolo Bonzini
On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: > Add trace events to audit MemoryRegionOps field such: > - are all the valid/impl fields provided? > - is the region a power of two? > > These cases are accepted, but it is interesting to list them. > > Example: > > $ qemu-system-i386 -S

[PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-06 Thread Philippe Mathieu-Daudé
Add trace events to audit MemoryRegionOps field such: - are all the valid/impl fields provided? - is the region a power of two? These cases are accepted, but it is interesting to list them. Example: $ qemu-system-i386 -S -trace memory_region_io_check\* memory_region_io_check_odd_size mr