Re: [PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices

2021-12-07 Thread Cédric Le Goater
On 12/7/21 10:40, Frederic Barrat wrote: On 02/12/2021 15:42, Cédric Le Goater wrote: All POWER8 machines have a maximum of 3 PHB3 devices. Adapt the PNV8_CHIP_PHB3_MAX definition for consistency. Signed-off-by: Cédric Le Goater --- The Naples chip (Garrison) can have 4 PHBs and it seems

Re: [PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices

2021-12-07 Thread Frederic Barrat
On 02/12/2021 15:42, Cédric Le Goater wrote: All POWER8 machines have a maximum of 3 PHB3 devices. Adapt the PNV8_CHIP_PHB3_MAX definition for consistency. Signed-off-by: Cédric Le Goater --- The Naples chip (Garrison) can have 4 PHBs and it seems we have a power8nvl machine type for

Re: [PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices

2021-12-02 Thread Cédric Le Goater
On 12/2/21 18:27, Daniel Henrique Barboza wrote: On 12/2/21 11:42, Cédric Le Goater wrote: All POWER8 machines have a maximum of 3 PHB3 devices. Adapt the PNV8_CHIP_PHB3_MAX definition for consistency. I suggest "3 PHB3 devices per chip" for clarity. Fixed. Thanks, C.

Re: [PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices

2021-12-02 Thread Daniel Henrique Barboza
On 12/2/21 11:42, Cédric Le Goater wrote: All POWER8 machines have a maximum of 3 PHB3 devices. Adapt the PNV8_CHIP_PHB3_MAX definition for consistency. I suggest "3 PHB3 devices per chip" for clarity. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza

[PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices

2021-12-02 Thread Cédric Le Goater
All POWER8 machines have a maximum of 3 PHB3 devices. Adapt the PNV8_CHIP_PHB3_MAX definition for consistency. Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv.h | 2 +- hw/ppc/pnv.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/ppc/pnv.h