Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules

Hi, > > +# > > +# common-obj-m has some crap here, probably as side effect from > > +# filling obj-y. Clear it. Fixes suspicious dependency errors when > > +# building devices as modules. > > +# > > +common-obj-m := > > This comment doesn't fill me with confidence - makes it feel like there's

Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules

On Fri, Jun 26, 2020 at 06:43:02PM +0200, Christophe de Dinechin wrote: > Signed-off-by: Gerd Hoffmann > Signed-off-by: Christophe de Dinechin > --- > Makefile.objs| 1 + > Makefile.target | 7 +++ > hw/Makefile.objs | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/Makefile.o

[PATCH 05/10] build: Avoid build failure when building drivers as modules

Signed-off-by: Gerd Hoffmann Signed-off-by: Christophe de Dinechin --- Makefile.objs| 1 + Makefile.target | 7 +++ hw/Makefile.objs | 1 + 3 files changed, 9 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index e38768c8d5..6703353493 100644 --- a/Makefile.objs +++ b/Makefile