Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 11:59:29PM +0200, Liran Alon wrote: > > On 10/03/2020 23:49, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 11:34:00PM +0200, Liran Alon wrote: > > > On 10/03/2020 23:16, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: >

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 23:49, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 11:34:00PM +0200, Liran Alon wrote: On 10/03/2020 23:16, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: There is no license issue here. It's only definitions. So it seems that in

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 11:34:00PM +0200, Liran Alon wrote: > > On 10/03/2020 23:16, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: > > > There is no license issue here. It's only definitions. > > So it seems that in your opinion > > - definition names

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 23:16, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: There is no license issue here. It's only definitions. So it seems that in your opinion - definition names in the interface do not need a license and - it is fair to reuse them without

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: > There is no license issue here. It's only definitions. So it seems that in your opinion - definition names in the interface do not need a license and - it is fair to reuse them without a license for the purpose of making your

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 19:36, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 06:39:33PM +0200, Liran Alon wrote: Isn't enum invented exactly for enumerating all possible values of a field? No - it just assigns names to constants. If you then proceed not to use the names, then it's pointless. It's

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 06:39:33PM +0200, Liran Alon wrote: > > > Isn't enum invented exactly for enumerating all possible values of a > > > field? > > No - it just assigns names to constants. If you then proceed not to use > > the names, then it's pointless. > It's not. It exactly lists all the

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 17:10, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: On 10/03/2020 16:08, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote: On 10/03/2020 14:53, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: > > On 10/03/2020 16:08, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote: > > > On 10/03/2020 14:53, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote: >

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 16:08, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote: On 10/03/2020 14:53, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote: On 10/03/2020 14:35, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote: > > On 10/03/2020 14:53, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote: > > > On 10/03/2020 14:35, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote: >

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 14:53, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote: On 10/03/2020 14:35, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote: On 10/03/2020 14:14, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote: > > On 10/03/2020 14:35, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote: > > > On 10/03/2020 14:14, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: >

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 14:35, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote: On 10/03/2020 14:14, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: As can be seen from VmCheck_GetVersion() in open-vm-tools code,

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote: > > On 10/03/2020 14:14, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: > > > As can be seen from VmCheck_GetVersion() in open-vm-tools code, > > > CMD_GETVERSION should return VMX type in ECX

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 14:14, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: As can be seen from VmCheck_GetVersion() in open-vm-tools code, CMD_GETVERSION should return VMX type in ECX register. Default is to fake host as VMware ESX server. But user can control

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: > As can be seen from VmCheck_GetVersion() in open-vm-tools code, > CMD_GETVERSION should return VMX type in ECX register. > > Default is to fake host as VMware ESX server. But user can control > this value by "-global

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:40:24PM +0200, Liran Alon wrote: > > On 10/03/2020 13:23, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:18:44PM +0200, Liran Alon wrote: > > > On 10/03/2020 11:20, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: >

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 13:23, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:18:44PM +0200, Liran Alon wrote: On 10/03/2020 11:20, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: As can be seen from VmCheck_GetVersion() in open-vm-tools code,

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:18:44PM +0200, Liran Alon wrote: > > On 10/03/2020 11:20, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: > > > As can be seen from VmCheck_GetVersion() in open-vm-tools code, > > > CMD_GETVERSION should return VMX type in ECX

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Liran Alon
On 10/03/2020 11:20, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: As can be seen from VmCheck_GetVersion() in open-vm-tools code, CMD_GETVERSION should return VMX type in ECX register. Default is to fake host as VMware ESX server. But user can control

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: > As can be seen from VmCheck_GetVersion() in open-vm-tools code, > CMD_GETVERSION should return VMX type in ECX register. > > Default is to fake host as VMware ESX server. But user can control > this value by "-global

[PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-09 Thread Liran Alon
As can be seen from VmCheck_GetVersion() in open-vm-tools code, CMD_GETVERSION should return VMX type in ECX register. Default is to fake host as VMware ESX server. But user can control this value by "-global vmport.vmx-type=X". Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon ---