Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-29 Thread John Snow
On Mon, Jun 28, 2021 at 5:40 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > > On 6/25/21 12:45 PM, John Snow wrote: > > This is a *third* way to run the Python tests. Unlike the first two > > (check-pipenv, check-tox), this version does not require any specific > > interpreter

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-28 Thread Wainer dos Santos Moschetta
On 6/25/21 12:45 PM, John Snow wrote: This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
On 6/25/21 3:01 PM, Willian Rampazzo wrote: On Fri, Jun 25, 2021 at 3:38 PM John Snow wrote: On 6/25/21 2:36 PM, Willian Rampazzo wrote: Maybe, it may confuse people using `make check-venv` under `tests`. Anyway, I'm not opposed to it. Reviewed-by: Willian Rampazzo I have to admit there's

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 3:38 PM John Snow wrote: > > On 6/25/21 2:36 PM, Willian Rampazzo wrote: > > Maybe, it may confuse people using `make check-venv` under `tests`. > > Anyway, I'm not opposed to it. > > > > Reviewed-by: Willian Rampazzo > > I have to admit there's much about Python packaging

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
On 6/25/21 2:36 PM, Willian Rampazzo wrote: Maybe, it may confuse people using `make check-venv` under `tests`. Anyway, I'm not opposed to it. Reviewed-by: Willian Rampazzo I have to admit there's much about Python packaging that is confusing :) Can you elaborate on your point for me,

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > This is a *third* way to run the Python tests. Unlike the first two > (check-pipenv, check-tox), this version does not require any specific > interpreter version -- making it a lot easier to tell people to run it > as a quick smoketest prior

[PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLab CI. Summary: Checked via GitLab