Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-11 Thread David Gibson
On Tue, Aug 10, 2021 at 04:32:35PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:50 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:47AM -0300, Daniel Henrique Barboza wrote: > > > From: Gustavo Romero > > > > > > An Event-Based Branch (EBB) allows applications to change

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Richard Henderson
On 8/10/21 9:32 AM, Daniel Henrique Barboza wrote: I'm not sure what is the disastree path. David meant decodetree. See insn32.decode. r~

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Richard Henderson
On 8/9/21 3:10 AM, Daniel Henrique Barboza wrote: +TCGv target = tcg_temp_new(); +TCGv bescr = tcg_temp_new(); + +gen_load_spr(target, SPR_EBBRR); +tcg_gen_mov_tl(cpu_nip, target); You don't need a temporary for target here; just load into cpu_nip directly. +

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-10 Thread Daniel Henrique Barboza
On 8/10/21 12:50 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:47AM -0300, Daniel Henrique Barboza wrote: From: Gustavo Romero An Event-Based Branch (EBB) allows applications to change the NIA when a event-based exception occurs. Event-based exceptions are enabled by setting the

Re: [PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-09 Thread David Gibson
On Mon, Aug 09, 2021 at 10:10:47AM -0300, Daniel Henrique Barboza wrote: > From: Gustavo Romero > > An Event-Based Branch (EBB) allows applications to change the NIA when a > event-based exception occurs. Event-based exceptions are enabled by > setting the Branch Event Status and Control

[PATCH 09/19] PPC64/TCG: Implement 'rfebb' instruction

2021-08-09 Thread Daniel Henrique Barboza
From: Gustavo Romero An Event-Based Branch (EBB) allows applications to change the NIA when a event-based exception occurs. Event-based exceptions are enabled by setting the Branch Event Status and Control Register (BESCR). If the event-based exception is enabled when the exception occurs, an