Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-02-15 Thread Kevin Wolf
Am 13.01.2021 um 15:15 hat Stefan Hajnoczi geschrieben: > On Wed, Jan 13, 2021 at 01:51:17PM +0100, BALATON Zoltan wrote: > > On Wed, 13 Jan 2021, Stefan Hajnoczi wrote: > > > On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote: > > > > On Tue, 12 Jan 2021, Stefan Hajnoczi wrote: > > > >

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-02-01 Thread Stefan Hajnoczi
On Tue, Jan 19, 2021 at 10:31:49AM -0600, Eric Blake wrote: > On 1/14/21 8:18 AM, BALATON Zoltan wrote: > > >> I wasn't aware of the fact that some of the utilities are sensitive to > >> '--' vs '-'! I'm in favor of consistently using '--' in documentation > >> but allowing both for backwards comp

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-19 Thread Eric Blake
On 1/14/21 8:18 AM, BALATON Zoltan wrote: >> I wasn't aware of the fact that some of the utilities are sensitive to >> '--' vs '-'! I'm in favor of consistently using '--' in documentation >> but allowing both for backwards compatibility where '-' is currently >> supported. >> >> If we are in agre

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-14 Thread John Snow
On 1/14/21 9:02 AM, Stefan Hajnoczi wrote: 1. Add a section to CODING_STYLE.rst or other developer documentation documenting this. 2. Convert existing documentation to use '--'. This will make it more consistent and also avoid confusion about '-' vs '--'. John: Do you have time to do t

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-14 Thread Stefan Hajnoczi
On Thu, Jan 14, 2021 at 03:18:48PM +0100, BALATON Zoltan wrote: > On Thu, 14 Jan 2021, Stefan Hajnoczi wrote: > > On Wed, Jan 13, 2021 at 07:20:42PM -0500, John Snow wrote: > > > On 1/13/21 6:45 PM, BALATON Zoltan wrote: > > > > > > > > Please don't. That would break all scripts that already call

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-14 Thread BALATON Zoltan
On Thu, 14 Jan 2021, Stefan Hajnoczi wrote: On Wed, Jan 13, 2021 at 07:20:42PM -0500, John Snow wrote: On 1/13/21 6:45 PM, BALATON Zoltan wrote: Please don't. That would break all scripts that already call qemu using single dash options. Forcing everyone to edit their scripts is not nice. How

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-14 Thread Stefan Hajnoczi
On Wed, Jan 13, 2021 at 07:20:42PM -0500, John Snow wrote: > On 1/13/21 6:45 PM, BALATON Zoltan wrote: > > > > Please don't. That would break all scripts that already call qemu using > > single dash options. Forcing everyone to edit their scripts is not nice. > > How about also accepting single da

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread John Snow
On 1/13/21 6:45 PM, BALATON Zoltan wrote: Please don't. That would break all scripts that already call qemu using single dash options. Forcing everyone to edit their scripts is not nice. How about also accepting single dash in qemu-img for consistency then you can use whatever you want in doc

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread BALATON Zoltan
On Wed, 13 Jan 2021, John Snow wrote: On 1/13/21 5:15 PM, Eric Blake wrote: On 1/13/21 3:42 PM, John Snow wrote: On 1/13/21 4:48 AM, Stefan Hajnoczi wrote: QEMU options are single dash with double dash accepted for compatibility but help and other docs have single dash so these (and below) sho

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread John Snow
On 1/13/21 5:15 PM, Eric Blake wrote: On 1/13/21 3:42 PM, John Snow wrote: On 1/13/21 4:48 AM, Stefan Hajnoczi wrote: QEMU options are single dash with double dash accepted for compatibility but help and other docs have single dash so these (and below) should be -trace. (Also a bit less typing

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread Eric Blake
On 1/13/21 3:42 PM, John Snow wrote: > On 1/13/21 4:48 AM, Stefan Hajnoczi wrote: >>> QEMU options are single dash with double dash accepted for >>> compatibility but >>> help and other docs have single dash so these (and below) should be >>> -trace. >>> (Also a bit less typing for otherwise alread

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread John Snow
On 1/13/21 4:48 AM, Stefan Hajnoczi wrote: QEMU options are single dash with double dash accepted for compatibility but help and other docs have single dash so these (and below) should be -trace. (Also a bit less typing for otherwise already way too long command lines.) Is this documented somewh

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread Stefan Hajnoczi
On Wed, Jan 13, 2021 at 01:51:17PM +0100, BALATON Zoltan wrote: > On Wed, 13 Jan 2021, Stefan Hajnoczi wrote: > > On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote: > > > On Tue, 12 Jan 2021, Stefan Hajnoczi wrote: > > > > It is possible to repeat the --trace option to specify multiple

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-13 Thread Stefan Hajnoczi
On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote: > On Tue, 12 Jan 2021, Stefan Hajnoczi wrote: > > It is possible to repeat the --trace option to specify multiple > > patterns. This may be preferrable to users who do not want to create a > > file with a list of patterns. > > > > Sug

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-12 Thread BALATON Zoltan
On Tue, 12 Jan 2021, Stefan Hajnoczi wrote: It is possible to repeat the --trace option to specify multiple patterns. This may be preferrable to users who do not want to create a file with a list of patterns. Suggested-by: BALATON Zoltan Signed-off-by: Stefan Hajnoczi --- docs/devel/tracing.rs

Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-12 Thread Philippe Mathieu-Daudé
On 1/12/21 5:58 PM, Stefan Hajnoczi wrote: > It is possible to repeat the --trace option to specify multiple > patterns. This may be preferrable to users who do not want to create a > file with a list of patterns. > > Suggested-by: BALATON Zoltan > Signed-off-by: Stefan Hajnoczi > --- > docs/de

[PATCH 1/2] trace: document how to specify multiple --trace patterns

2021-01-12 Thread Stefan Hajnoczi
It is possible to repeat the --trace option to specify multiple patterns. This may be preferrable to users who do not want to create a file with a list of patterns. Suggested-by: BALATON Zoltan Signed-off-by: Stefan Hajnoczi --- docs/devel/tracing.rst | 9 +++-- 1 file changed, 7 insertions