Re: [PATCH 1/4] sm501: Fix bounds checks

2020-06-15 Thread BALATON Zoltan
On Mon, 15 Jun 2020, Peter Maydell wrote: On Mon, 15 Jun 2020 at 17:40, BALATON Zoltan wrote: On Mon, 15 Jun 2020, Peter Maydell wrote: The calculations for sb/se/db/de all have a term which multiplies by (width + pitch), which makes me suspect they also need a similar fix ? Maybe. I'll

Re: [PATCH 1/4] sm501: Fix bounds checks

2020-06-15 Thread Peter Maydell
On Mon, 15 Jun 2020 at 17:40, BALATON Zoltan wrote: > > On Mon, 15 Jun 2020, Peter Maydell wrote: > > The calculations for sb/se/db/de all have a term which > > multiplies by (width + pitch), which makes me suspect > > they also need a similar fix ? > > Maybe. I'll have to check again. Actually

Re: [PATCH 1/4] sm501: Fix bounds checks

2020-06-15 Thread BALATON Zoltan
On Mon, 15 Jun 2020, Peter Maydell wrote: On Sat, 6 Jun 2020 at 20:22, BALATON Zoltan wrote: We don't need to add width to pitch when calculating last point, that would reject valid ops within the card's local_mem. Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 Signed-off-by: BALATON Zoltan

Re: [PATCH 1/4] sm501: Fix bounds checks

2020-06-15 Thread Peter Maydell
On Sat, 6 Jun 2020 at 20:22, BALATON Zoltan wrote: > > We don't need to add width to pitch when calculating last point, that > would reject valid ops within the card's local_mem. > > Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 8

[PATCH 1/4] sm501: Fix bounds checks

2020-06-06 Thread BALATON Zoltan
We don't need to add width to pitch when calculating last point, that would reject valid ops within the card's local_mem. Fixes: b15a22bbcbe6a78dc3d88fe3134985e4cdd87de4 Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff