Re: [PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-25 Thread Greg Kurz
On Fri, 23 Oct 2020 21:19:19 +0200 Igor Mammedov wrote: > On Mon, 19 Oct 2020 10:48:04 +0200 > Greg Kurz wrote: > > > pc_dimm_plug() doesn't use it. It only aborts on error. > > > > Drop @errp and adapt the callers accordingly. > > > > Signed-off-by: Greg Kurz > Reviewed-by: Igor Mammedov >

Re: [PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-23 Thread Igor Mammedov
On Mon, 19 Oct 2020 10:48:04 +0200 Greg Kurz wrote: > pc_dimm_plug() doesn't use it. It only aborts on error. > > Drop @errp and adapt the callers accordingly. > > Signed-off-by: Greg Kurz Reviewed-by: Igor Mammedov arguably the same should be done in spapr. > --- > hw/arm/virt.c

Re: [PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-21 Thread David Gibson
On Mon, Oct 19, 2020 at 10:48:04AM +0200, Greg Kurz wrote: > pc_dimm_plug() doesn't use it. It only aborts on error. > > Drop @errp and adapt the callers accordingly. > > Signed-off-by: Greg Kurz Reviewed-by: David Gibson ppc parts Acked-by: David Gibson > --- > hw/arm/virt.c|

Re: [PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-21 Thread Vladimir Sementsov-Ogievskiy
19.10.2020 11:48, Greg Kurz wrote: pc_dimm_plug() doesn't use it. It only aborts on error. Drop @errp and adapt the callers accordingly. Signed-off-by: Greg Kurz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-19 Thread Greg Kurz
pc_dimm_plug() doesn't use it. It only aborts on error. Drop @errp and adapt the callers accordingly. Signed-off-by: Greg Kurz --- hw/arm/virt.c|9 + hw/i386/pc.c |8 +--- hw/mem/pc-dimm.c |2 +- hw/ppc/spapr.c |5 + incl