Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-08 Thread Igor Mammedov
On Mon, 7 Dec 2020 23:32:55 -0300 Daniel Henrique Barboza wrote: > On 12/7/20 1:07 PM, Igor Mammedov wrote: > > On Wed, 2 Dec 2020 03:18:49 -0500 > > Paolo Bonzini wrote: > > > >> Machine options can be retrieved as properties of the machine object. > >> Encourage that by removing the

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-08 Thread Paolo Bonzini
On 08/12/20 03:16, Daniel Henrique Barboza wrote: 2) find a way to make object_property_get_str() to return kvm_type = NULL if the 'kvm_type' option is absent and keep spapr code untouched. I don't have the knowledge to assess how hard this would be. 3) I can change the pseries logic to add

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-07 Thread Daniel Henrique Barboza
On 12/7/20 1:07 PM, Igor Mammedov wrote: On Wed, 2 Dec 2020 03:18:49 -0500 Paolo Bonzini wrote: Machine options can be retrieved as properties of the machine object. Encourage that by removing the "easy" accessor to machine options. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-07 Thread Daniel Henrique Barboza
On 12/2/20 5:18 AM, Paolo Bonzini wrote: Machine options can be retrieved as properties of the machine object. Encourage that by removing the "easy" accessor to machine options. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 11 --- hw/arm/boot.c | 2 +-

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-07 Thread Paolo Bonzini
On 07/12/20 17:07, Igor Mammedov wrote: On Wed, 2 Dec 2020 03:18:49 -0500 Paolo Bonzini wrote: Machine options can be retrieved as properties of the machine object. Encourage that by removing the "easy" accessor to machine options. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c

Re: [PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-07 Thread Igor Mammedov
On Wed, 2 Dec 2020 03:18:49 -0500 Paolo Bonzini wrote: > Machine options can be retrieved as properties of the machine object. > Encourage that by removing the "easy" accessor to machine options. > > Signed-off-by: Paolo Bonzini > --- > accel/kvm/kvm-all.c | 11 --- >

[PATCH 10/15] vl: make qemu_get_machine_opts static

2020-12-02 Thread Paolo Bonzini
Machine options can be retrieved as properties of the machine object. Encourage that by removing the "easy" accessor to machine options. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 11 --- hw/arm/boot.c | 2 +- hw/microblaze/boot.c| 9 -