Re: [PATCH 16/21] hw/net/can/versal: Prefer object_initialize_child over object_initialize

2024-02-23 Thread Pavel Pisa via 
On Friday 23 of February 2024 12:06:34 Francisco Iglesias wrote:
> On 2024-02-16 12:03, Philippe Mathieu-Daudé wrote:
> > When the QOM parent is available, prefer object_initialize_child()
> > over object_initialize(), since it create the parent relationship.
> >
> > Signed-off-by: Philippe Mathieu-Daudé 
>
> Reviewed-by: Francisco Iglesias 

Reviewed-by: Pavel Pisa

Re: [PATCH 16/21] hw/net/can/versal: Prefer object_initialize_child over object_initialize

2024-02-23 Thread Francisco Iglesias 

On 2024-02-16 12:03, Philippe Mathieu-Daudé wrote:

When the QOM parent is available, prefer object_initialize_child()
over object_initialize(), since it create the parent relationship.

Signed-off-by: Philippe Mathieu-Daudé 


Reviewed-by: Francisco Iglesias 



---
  hw/net/can/xlnx-versal-canfd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c
index 47a14cfe63..f8e4bd75e4 100644
--- a/hw/net/can/xlnx-versal-canfd.c
+++ b/hw/net/can/xlnx-versal-canfd.c
@@ -1900,7 +1900,7 @@ static int canfd_populate_regarray(XlnxVersalCANFDState 
*s,
  int index = rae[i].addr / 4;
  RegisterInfo *r = >reg_info[index];
  
-object_initialize(r, sizeof(*r), TYPE_REGISTER);

+object_initialize_child(OBJECT(s), "reg[*]", r, TYPE_REGISTER);
  
  *r = (RegisterInfo) {

  .data = >regs[index],

[PATCH 16/21] hw/net/can/versal: Prefer object_initialize_child over object_initialize

2024-02-16 Thread Philippe Mathieu-Daudé 
When the QOM parent is available, prefer object_initialize_child()
over object_initialize(), since it create the parent relationship.

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/net/can/xlnx-versal-canfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c
index 47a14cfe63..f8e4bd75e4 100644
--- a/hw/net/can/xlnx-versal-canfd.c
+++ b/hw/net/can/xlnx-versal-canfd.c
@@ -1900,7 +1900,7 @@ static int canfd_populate_regarray(XlnxVersalCANFDState 
*s,
 int index = rae[i].addr / 4;
 RegisterInfo *r = >reg_info[index];
 
-object_initialize(r, sizeof(*r), TYPE_REGISTER);
+object_initialize_child(OBJECT(s), "reg[*]", r, TYPE_REGISTER);
 
 *r = (RegisterInfo) {
 .data = >regs[index],
-- 
2.41.0