Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Paolo Bonzini 

On 5/3/23 11:12, Alex Bennée wrote:

These are needed for board creation so fail under "make check" with a
--without-default-devices build.

Signed-off-by: Alex Bennée
---
  hw/xtensa/Kconfig | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
index 0740657ea5..a54a9d395e 100644
--- a/hw/xtensa/Kconfig
+++ b/hw/xtensa/Kconfig
@@ -6,6 +6,8 @@ config XTENSA_VIRT
  select XTENSA_SIM
  select PCI_EXPRESS_GENERIC_BRIDGE
  select PCI_DEVICES
+select VIRTIO_PCI
+select VIRTIO_NET


Not needed.

Paolo

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Max Filippov 
On Wed, May 3, 2023 at 2:12 AM Alex Bennée  wrote:
>
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
>
> Signed-off-by: Alex Bennée 
> ---
>  hw/xtensa/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Max Filippov 

-- 
Thanks.
-- Max

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Richard Henderson 

On 5/3/23 10:12, Alex Bennée wrote:

These are needed for board creation so fail under "make check" with a
--without-default-devices build.

Signed-off-by: Alex Bennée 
---
  hw/xtensa/Kconfig | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
index 0740657ea5..a54a9d395e 100644
--- a/hw/xtensa/Kconfig
+++ b/hw/xtensa/Kconfig
@@ -6,6 +6,8 @@ config XTENSA_VIRT
  select XTENSA_SIM
  select PCI_EXPRESS_GENERIC_BRIDGE
  select PCI_DEVICES
+select VIRTIO_PCI
+select VIRTIO_NET
  
  config XTENSA_XTFPGA

  bool


Reviewed-by: Richard Henderson 

r~

[PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Alex Bennée 
These are needed for board creation so fail under "make check" with a
--without-default-devices build.

Signed-off-by: Alex Bennée 
---
 hw/xtensa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
index 0740657ea5..a54a9d395e 100644
--- a/hw/xtensa/Kconfig
+++ b/hw/xtensa/Kconfig
@@ -6,6 +6,8 @@ config XTENSA_VIRT
 select XTENSA_SIM
 select PCI_EXPRESS_GENERIC_BRIDGE
 select PCI_DEVICES
+select VIRTIO_PCI
+select VIRTIO_NET
 
 config XTENSA_XTFPGA
 bool
-- 
2.39.2