Re: [PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-08 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 7 Feb 2020 at 16:54, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > The MigrationInfo::setup-time documentation is the only place where >> > we use _this_ inline markup to mean italics. >> >> Nitpick: _this_ does not mean italics, it means

Re: [PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-07 Thread Peter Maydell
On Fri, 7 Feb 2020 at 16:54, Markus Armbruster wrote: > > Peter Maydell writes: > > > The MigrationInfo::setup-time documentation is the only place where > > we use _this_ inline markup to mean italics. > > Nitpick: _this_ does not mean italics, it means emphasis. See > qapi-code-gen.txt

Re: [PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-07 Thread Markus Armbruster
Peter Maydell writes: > The MigrationInfo::setup-time documentation is the only place where > we use _this_ inline markup to mean italics. Nitpick: _this_ does not mean italics, it means emphasis. See qapi-code-gen.txt section "Documentation markup". doc.py maps it to @emph{this}, which

[PATCH 18/29] qapi/migration.json: Replace _this_ with *this*

2020-02-06 Thread Peter Maydell
The MigrationInfo::setup-time documentation is the only place where we use _this_ inline markup to mean italics. rST doesn't recognize that markup and emits literal underscores. Switch to *this* instead; for the texinfo output this will be bold, and for rST it will go back to being italics.