Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 11:49:17AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 09.07.2020 11:29, Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Keep-alive won't hurt, let's try to enable it even if not requested by > > >

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 7/9/20 11:29 AM, Daniel P. Berrangé wrote: >> On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> Keep-alive won't hurt, let's try to enable it even if not requested by >>> user. >> Keep-alive intentionally breaks TCP connections

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Denis V. Lunev
On 7/9/20 11:29 AM, Daniel P. Berrangé wrote: > On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Keep-alive won't hurt, let's try to enable it even if not requested by >> user. > Keep-alive intentionally breaks TCP connections earlier than normal > in face of

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Vladimir Sementsov-Ogievskiy
09.07.2020 11:29, Daniel P. Berrangé wrote: On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: Keep-alive won't hurt, let's try to enable it even if not requested by user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient

Re: [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-09 Thread Daniel P . Berrangé
On Wed, Jul 08, 2020 at 10:15:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Keep-alive won't hurt, let's try to enable it even if not requested by > user. Keep-alive intentionally breaks TCP connections earlier than normal in face of transient networking problems. The question is more about

[PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default

2020-07-08 Thread Vladimir Sementsov-Ogievskiy
Keep-alive won't hurt, let's try to enable it even if not requested by user. Signed-off-by: Vladimir Sementsov-Ogievskiy --- util/qemu-sockets.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index