Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-02 Thread Richard Henderson
On 1/2/23 02:10, Mark Cave-Ayland wrote: I think you need an "abs(floatx80_to_int32())" in both cases as you do in PATCH 4 Or in fact sign = extractFloatx80Sign(res); quot = floatx80_to_int32(floatx80_abs(res->d), status); make_quotient(env, sign, quot); Thanks for the

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-02 Thread Mark Cave-Ayland
On 01/01/2023 18:53, Richard Henderson wrote: On 1/1/23 09:26, Laurent Vivier wrote: Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed.

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-02 Thread Mark Cave-Ayland
On 01/01/2023 17:26, Laurent Vivier wrote: Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland ---  

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Richard Henderson
On 1/1/23 09:26, Laurent Vivier wrote: Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland ---  

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file

[PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Mark Cave-Ayland
This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git