Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

2021-01-07 Thread BALATON Zoltan
On Thu, 7 Jan 2021, Greg Kurz wrote: On Thu, 7 Jan 2021 10:45:26 +0100 BALATON Zoltan wrote: On Thu, 7 Jan 2021, Greg Kurz wrote: On Wed, 6 Jan 2021 16:24:01 +0100 BALATON Zoltan via wrote: Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus(). Also remove the check for

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

2021-01-07 Thread Greg Kurz
On Thu, 7 Jan 2021 10:45:26 +0100 BALATON Zoltan wrote: > On Thu, 7 Jan 2021, Greg Kurz wrote: > > On Wed, 6 Jan 2021 16:24:01 +0100 > > BALATON Zoltan via wrote: > > > >> Use the PCI_BUS type cast macro to convert result of > >> qdev_get_child_bus(). Also remove the check for NULL afterwards wh

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

2021-01-07 Thread BALATON Zoltan
On Thu, 7 Jan 2021, Greg Kurz wrote: On Wed, 6 Jan 2021 16:24:01 +0100 BALATON Zoltan via wrote: Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus(). Also remove the check for NULL afterwards which should not be needed because sysbus_create_simple() uses error_abort It

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

2021-01-07 Thread Greg Kurz
On Wed, 6 Jan 2021 16:24:01 +0100 BALATON Zoltan via wrote: > Use the PCI_BUS type cast macro to convert result of > qdev_get_child_bus(). Also remove the check for NULL afterwards which > should not be needed because sysbus_create_simple() uses error_abort It seems to me that sysbus_create_simp

[PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

2021-01-06 Thread BALATON Zoltan via
Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus(). Also remove the check for NULL afterwards which should not be needed because sysbus_create_simple() uses error_abort and PCI_BUS macro also checks its argument by default so this shouldn't fail here. Signed-off-by: BALATON