Re: [PATCH 3/3] target/riscv: Consider priv spec version when generating ISA string

2022-05-04 Thread Alistair Francis
On Sat, Apr 30, 2022 at 2:31 PM Anup Patel wrote: > > On Sat, Apr 30, 2022 at 8:39 AM Frank Chang wrote: > > > > Hi Anup, > > > > If we want to limit the generated ISA string to/after a specific privilege > > spec version. > > Shouldn't we also check the privilege spec version when these

Re: [PATCH 3/3] target/riscv: Consider priv spec version when generating ISA string

2022-04-29 Thread Frank Chang
On Sat, Apr 30, 2022 at 12:30 PM Anup Patel wrote: > On Sat, Apr 30, 2022 at 8:39 AM Frank Chang > wrote: > > > > Hi Anup, > > > > If we want to limit the generated ISA string to/after a specific > privilege spec version. > > Shouldn't we also check the privilege spec version when these

Re: [PATCH 3/3] target/riscv: Consider priv spec version when generating ISA string

2022-04-29 Thread Anup Patel
On Sat, Apr 30, 2022 at 8:39 AM Frank Chang wrote: > > Hi Anup, > > If we want to limit the generated ISA string to/after a specific privilege > spec version. > Shouldn't we also check the privilege spec version when these extensions are > enabled? > Otherwise, it's possible that one extension

Re: [PATCH 3/3] target/riscv: Consider priv spec version when generating ISA string

2022-04-29 Thread Frank Chang
Hi Anup, If we want to limit the generated ISA string to/after a specific privilege spec version. Shouldn't we also check the privilege spec version when these extensions are enabled? Otherwise, it's possible that one extension is enabled, but the privilege spec version is smaller than the one in

[PATCH 3/3] target/riscv: Consider priv spec version when generating ISA string

2022-04-29 Thread Anup Patel
Most of the multi-letter extensions (such as Svpbmt, Svnapot, Svinval, etc) are only available after Priv spec v1.12 so ISA string generation should check the minimum required priv spec version for all extensions. Fixes: a775398be2e ("target/riscv: Add isa extenstion strings to the device tree")