Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-27 Thread Daniele Buono
Hi Stefan, a quick clarification on configure: right now, in configure, there's * "Advanced Options (experts only)" which usually don't have both enable and disable for each option, and * "Optional features, enabled with --enable-FEATURE and disabled with --disable-FEATURE, default is enabled if

Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-27 Thread Stefan Hajnoczi
On Fri, May 22, 2020 at 11:24:46AM -0400, Daniele Buono wrote: > I would feel more confident by adding another check in configure to make > sure that the user didn't enable SafeStack manually through other means, > like manually setting the option through extra_cflags. > What do you think? Sure, a

Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-22 Thread Daniele Buono
Hi Stefan, I would feel more confident by adding another check in configure to make sure that the user didn't enable SafeStack manually through other means, like manually setting the option through extra_cflags. What do you think? On 5/21/2020 5:52 AM, Stefan Hajnoczi wrote: On Wed, Apr 29, 202

Re: [PATCH 3/4] configure: add flag to enable SafeStack

2020-05-21 Thread Stefan Hajnoczi
On Wed, Apr 29, 2020 at 03:44:19PM -0400, Daniele Buono wrote: > This patch adds a flag to enable the SafeStack instrumentation provided > by LLVM. > The checks make sure that the compiler supports the flags, and that we > are using the proper coroutine implementation (coroutine-ucontext). > While

[PATCH 3/4] configure: add flag to enable SafeStack

2020-04-29 Thread Daniele Buono
This patch adds a flag to enable the SafeStack instrumentation provided by LLVM. The checks make sure that the compiler supports the flags, and that we are using the proper coroutine implementation (coroutine-ucontext). While SafeStack is supported only on Linux, NetBSD, FreeBSD and macOS, we are n