Re: [PATCH 4/4] virtio-mmio: cleanup reset

2022-06-09 Thread Paolo Bonzini
On 6/9/22 14:22, Cornelia Huck wrote: -if (proxy->legacy) { -return; -} +virtio_bus_reset(>bus); -for (i = 0; i < VIRTIO_QUEUE_MAX; i++) { -proxy->vqs[i].enabled = 0; +if (!proxy->legacy) { +for (i = 0; i < VIRTIO_QUEUE_MAX; i++) { +

Re: [PATCH 4/4] virtio-mmio: cleanup reset

2022-06-09 Thread Cornelia Huck
On Thu, Jun 09 2022, Paolo Bonzini wrote: > Make virtio_mmio_soft_reset reset the virtio device, which is performed by > both the "soft" and the "hard" reset; and then call virtio_mmio_soft_reset > from virtio_mmio_reset to emphasize that the latter is a superset of the > former. > >

[PATCH 4/4] virtio-mmio: cleanup reset

2022-06-09 Thread Paolo Bonzini
Make virtio_mmio_soft_reset reset the virtio device, which is performed by both the "soft" and the "hard" reset; and then call virtio_mmio_soft_reset from virtio_mmio_reset to emphasize that the latter is a superset of the former. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-mmio.c | 17