Re: [PATCH 4/6] target/xtensa: use tcg_constant_* for numbered special registers

[Richard Henderson]

On 4/21/22 14:39, Max Filippov wrote:

Numbered special registers are small arrays of consecutive SRs. Use
tcg_constant_* for the SR index.

Signed-off-by: Max Filippov
---
  target/xtensa/translate.c | 16 
  1 file changed, 4 insertions(+), 12 deletions(-)


Reviewed-by: Richard Henderson 

r~

[PATCH 4/6] target/xtensa: use tcg_constant_* for numbered special registers

[Max Filippov]

Numbered special registers are small arrays of consecutive SRs. Use
tcg_constant_* for the SR index.

Signed-off-by: Max Filippov 
---
 target/xtensa/translate.c | 16 
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 82a0dbf46d7c..c4991735ead7 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -2615,15 +2615,13 @@ static void translate_wsr_ccompare(DisasContext *dc, 
const OpcodeArg arg[],
 {
 #ifndef CONFIG_USER_ONLY
 uint32_t id = par[0] - CCOMPARE;
-TCGv_i32 tmp = tcg_const_i32(id);
 
 assert(id < dc->config->nccompare);
 if (tb_cflags(dc->base.tb) & CF_USE_ICOUNT) {
 gen_io_start();
 }
 tcg_gen_mov_i32(cpu_SR[par[0]], arg[0].in);
-gen_helper_update_ccompare(cpu_env, tmp);
-tcg_temp_free(tmp);
+gen_helper_update_ccompare(cpu_env, tcg_constant_i32(id));
 #endif
 }
 
@@ -2643,11 +2641,9 @@ static void translate_wsr_dbreaka(DisasContext *dc, 
const OpcodeArg arg[],
 {
 #ifndef CONFIG_USER_ONLY
 unsigned id = par[0] - DBREAKA;
-TCGv_i32 tmp = tcg_const_i32(id);
 
 assert(id < dc->config->ndbreak);
-gen_helper_wsr_dbreaka(cpu_env, tmp, arg[0].in);
-tcg_temp_free(tmp);
+gen_helper_wsr_dbreaka(cpu_env, tcg_constant_i32(id), arg[0].in);
 #endif
 }
 
@@ -2656,11 +2652,9 @@ static void translate_wsr_dbreakc(DisasContext *dc, 
const OpcodeArg arg[],
 {
 #ifndef CONFIG_USER_ONLY
 unsigned id = par[0] - DBREAKC;
-TCGv_i32 tmp = tcg_const_i32(id);
 
 assert(id < dc->config->ndbreak);
-gen_helper_wsr_dbreakc(cpu_env, tmp, arg[0].in);
-tcg_temp_free(tmp);
+gen_helper_wsr_dbreakc(cpu_env, tcg_constant_i32(id), arg[0].in);
 #endif
 }
 
@@ -2669,11 +2663,9 @@ static void translate_wsr_ibreaka(DisasContext *dc, 
const OpcodeArg arg[],
 {
 #ifndef CONFIG_USER_ONLY
 unsigned id = par[0] - IBREAKA;
-TCGv_i32 tmp = tcg_const_i32(id);
 
 assert(id < dc->config->nibreak);
-gen_helper_wsr_ibreaka(cpu_env, tmp, arg[0].in);
-tcg_temp_free(tmp);
+gen_helper_wsr_ibreaka(cpu_env, tcg_constant_i32(id), arg[0].in);
 #endif
 }
 
-- 
2.30.2