Re: [PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 7:53 AM, Markus Armbruster wrote: BALATON Zoltan writes: There are several definitions of MAX_IDE_BUS in different boards (some of them unused) with the same value. Move it to include/hw/ide/internal.h to have it in a central place. Signed-off-by: BALATON Zoltan This one feels

Re: [PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header

2020-03-16 Thread Markus Armbruster
BALATON Zoltan writes: > There are several definitions of MAX_IDE_BUS in different boards (some > of them unused) with the same value. Move it to include/hw/ide/internal.h > to have it in a central place. > > Signed-off-by: BALATON Zoltan This one feels a bit questionable. The number of

[PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header

2020-03-13 Thread BALATON Zoltan
There are several definitions of MAX_IDE_BUS in different boards (some of them unused) with the same value. Move it to include/hw/ide/internal.h to have it in a central place. Signed-off-by: BALATON Zoltan --- hw/alpha/dp264.c | 2 -- hw/hppa/machine.c | 2 -- hw/i386/pc_piix.c