Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-07 Thread Vitaly Kuznetsov
Igor Mammedov wrote: > my preferred approach is still -cpu hyperv=on, since it doesn't > depend on order CLI is currently parsed (which is fragile thing), > but rather on what user asked us to do with CPU. I think I'm OK with this solution for the time being. When non-CPU devices arrive and if

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Eduardo Habkost
On Wed, Jan 06, 2021 at 05:45:42PM +0100, Igor Mammedov wrote: > On Wed, 06 Jan 2021 14:38:56 +0100 > Vitaly Kuznetsov wrote: > > > Igor Mammedov writes: > > > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > > Vitaly Kuznetsov wrote: > > > > > >> Igor Mammedov writes: > > >> > > >> > On Tue,

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Eduardo Habkost
On Wed, Jan 06, 2021 at 02:38:56PM +0100, Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 05 Jan 2021 12:50:05 +0100 > >> > > >> > I think there is a misunderstanding, idea w

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Igor Mammedov
On Wed, 06 Jan 2021 14:38:56 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 05 Jan 2021 17:31:43 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 05 Jan 2021 12:50:05 +0100 > >> > > >> > I think there is a misunderstanding, idea wa

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 05 Jan 2021 17:31:43 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Tue, 05 Jan 2021 12:50:05 +0100 >> > >> > I think there is a misunderstanding, idea was: >> > >> > cpu_initfn() { >> > //current set >> > cpu->default_hyperv_cpu_f

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-06 Thread Igor Mammedov
On Tue, 05 Jan 2021 17:31:43 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 05 Jan 2021 12:50:05 +0100 > > > > I think there is a misunderstanding, idea was: > > > > cpu_initfn() { > > //current set > > cpu->default_hyperv_cpu_features = ACD > > } > > > > compat_pro

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Eduardo Habkost
On Tue, Jan 05, 2021 at 05:31:41PM +0100, Igor Mammedov wrote: > On Tue, 5 Jan 2021 09:34:31 -0500 > Eduardo Habkost wrote: > > > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > > > On Mon, 4 Jan 2021 13:29:06 -0500 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Jan 04, 2

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Igor Mammedov writes: ... > > i was talking about user interface here, i.e.: > (QMP) create_machine(hyperv=on) > (QMP) device_add(cpu, hv_foo=x) > vs: > (QMP) device_add(cpu, hyperv_defaults=on,=onhv_foo=x) > > i.e. in the later case cpu specific options are consolidate within device > stanza

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 05 Jan 2021 16:10:36 +0100 Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > >> > >> documenting is good, but if it adds new semantics to how CPU features are > >> handled > >> users up the stack will need code i

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 05 Jan 2021 12:50:05 +0100 > > I think there is a misunderstanding, idea was: > > cpu_initfn() { > //current set > cpu->default_hyperv_cpu_features = ACD > } > > compat_props_5.1 { >cpu.default_hyperv_cpu_features = AB > } > > compat_props_5.2 { >cp

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 5 Jan 2021 09:34:31 -0500 Eduardo Habkost wrote: > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > > On Mon, 4 Jan 2021 13:29:06 -0500 > > Eduardo Habkost wrote: > > > > > On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > > > > Igor Mammedov write

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 05 Jan 2021 12:50:05 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Mon, 04 Jan 2021 13:54:32 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> >> > > >> >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> >> > +x86mc->def

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: >> >> documenting is good, but if it adds new semantics to how CPU features are >> handled >> users up the stack will need code it up as well and juggle with >> -machine + -cpu + -device cpu-foo >> not to

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Eduardo Habkost
On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > On Mon, 4 Jan 2021 13:29:06 -0500 > Eduardo Habkost wrote: > > > On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > > > Igor Mammedov writes: > > > > > > >> > > > > >> > +/* Hyper-V features enabled with '

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Mon, 04 Jan 2021 13:54:32 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> >> > >> >> > +/* Hyper-V features enabled with 'hyperv=on' */ >> >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | >> >> > +BIT(HYPERV_FEAT_VA

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Igor Mammedov
On Mon, 4 Jan 2021 13:29:06 -0500 Eduardo Habkost wrote: > On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > > Igor Mammedov writes: > > > > >> > > > >> > +/* Hyper-V features enabled with 'hyperv=on' */ > > >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RE

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Igor Mammedov
On Mon, 04 Jan 2021 13:54:32 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > >> > > >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | > >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) | > >>

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Eduardo Habkost
On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > >> > > >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | > >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) |

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Vitaly Kuznetsov
Igor Mammedov writes: >> > >> > +/* Hyper-V features enabled with 'hyperv=on' */ >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) | >> > +BIT(HYPERV_FEAT_CRASH) | BIT(HYPERV_FEAT_RESET) | >> > +

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-21 Thread David Hildenbrand
> Am 21.12.2020 um 20:47 schrieb Eduardo Habkost : > > +s390 maintainers, a question about feature groups below: > >> On Mon, Dec 21, 2020 at 02:24:18PM +0100, Igor Mammedov wrote: >> On Fri, 18 Dec 2020 13:07:21 -0500 >> Eduardo Habkost wrote: >> >>> On Fri, Dec 18, 2020 at 06:13:40PM +0100

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-21 Thread Eduardo Habkost
+s390 maintainers, a question about feature groups below: On Mon, Dec 21, 2020 at 02:24:18PM +0100, Igor Mammedov wrote: > On Fri, 18 Dec 2020 13:07:21 -0500 > Eduardo Habkost wrote: > > > On Fri, Dec 18, 2020 at 06:13:40PM +0100, Igor Mammedov wrote: > > > On Wed, 16 Dec 2020 15:52:02 -0500 > >

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-21 Thread Igor Mammedov
On Fri, 18 Dec 2020 13:07:21 -0500 Eduardo Habkost wrote: > On Fri, Dec 18, 2020 at 06:13:40PM +0100, Igor Mammedov wrote: > > On Wed, 16 Dec 2020 15:52:02 -0500 > > Eduardo Habkost wrote: > > > > > On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: > > > > Enabling Hyper-V e

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-18 Thread Eduardo Habkost
On Fri, Dec 18, 2020 at 06:13:40PM +0100, Igor Mammedov wrote: > On Wed, 16 Dec 2020 15:52:02 -0500 > Eduardo Habkost wrote: > > > On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: > > > Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > > > requires listin

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-18 Thread Igor Mammedov
On Wed, 16 Dec 2020 15:52:02 -0500 Eduardo Habkost wrote: > On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: > > Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > > requires listing all currently supported enlightenments ("hv_*" CPU > > features) explicit

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-17 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: >> Enabling Hyper-V emulation for a Windows VM is a tiring experience as it >> requires listing all currently supported enlightenments ("hv_*" CPU >> features) explicitly. We do have a 'hv_passthrough' mod

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-16 Thread Eduardo Habkost
On Thu, Nov 19, 2020 at 11:32:21AM +0100, Vitaly Kuznetsov wrote: > Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > requires listing all currently supported enlightenments ("hv_*" CPU > features) explicitly. We do have a 'hv_passthrough' mode enabling > everything but it

[PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-11-19 Thread Vitaly Kuznetsov
Enabling Hyper-V emulation for a Windows VM is a tiring experience as it requires listing all currently supported enlightenments ("hv_*" CPU features) explicitly. We do have a 'hv_passthrough' mode enabling everything but it can't be used in production as it prevents migration. Introduce a simple