Re: [PATCH 5/5] net/tap: net_init_tap_one(): fix net-client leak on failure path

2021-12-23 Thread Vladimir Sementsov-Ogievskiy
12.01.2021 07:53, Jason Wang wrote: On 2020/12/22 上午3:06, Vladimir Sementsov-Ogievskiy wrote: net_tap_fd_init() allocates new NetClientState through qemu_new_net_client(). We should free it on failure path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Attention: it's an intuitive patch.

Re: [PATCH 5/5] net/tap: net_init_tap_one(): fix net-client leak on failure path

2021-01-11 Thread Jason Wang
On 2020/12/22 上午3:06, Vladimir Sementsov-Ogievskiy wrote: net_tap_fd_init() allocates new NetClientState through qemu_new_net_client(). We should free it on failure path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Attention: it's an intuitive patch. I see, that net-client is leaked.

[PATCH 5/5] net/tap: net_init_tap_one(): fix net-client leak on failure path

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
net_tap_fd_init() allocates new NetClientState through qemu_new_net_client(). We should free it on failure path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Attention: it's an intuitive patch. I see, that net-client is leaked. May be it's still freed some tricky way? And I don't understand