Re: [PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()

[Dr. David Alan Gilbert]

* Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote:
> hmp_handle_error() does Error check internally.
> 
> Signed-off-by: Mao Zhongyi 

Reviewed-by: Dr. David Alan Gilbert 

> ---
>  monitor/hmp-cmds.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 6938f1060e..acdd6baff3 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -1636,9 +1636,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict)
>  obj = user_creatable_add_opts(opts, );
>  qemu_opts_del(opts);
>  
> -if (err) {
> -hmp_handle_error(mon, err);
> -}
> +hmp_handle_error(mon, err);
> +
>  if (obj) {
>  object_unref(obj);
>  }
> -- 
> 2.17.1
> 
> 
> 
> 
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error()

[Mao Zhongyi]

hmp_handle_error() does Error check internally.

Signed-off-by: Mao Zhongyi 
---
 monitor/hmp-cmds.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 6938f1060e..acdd6baff3 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1636,9 +1636,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict)
 obj = user_creatable_add_opts(opts, );
 qemu_opts_del(opts);
 
-if (err) {
-hmp_handle_error(mon, err);
-}
+hmp_handle_error(mon, err);
+
 if (obj) {
 object_unref(obj);
 }
-- 
2.17.1