Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 3/16/20 7:23 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 13/03/20 23:16, BALATON Zoltan wrote: > > +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); > +    pci_ide_create_devs(pci_dev); Additionally, I

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 7:23 AM, Markus Armbruster wrote: Paolo Bonzini writes: On 13/03/20 23:16, BALATON Zoltan wrote: +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); +    pci_ide_create_devs(pci_dev); Additionally, I think it may also make sense to move pci_ide_create_devs call into

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-16 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/03/20 23:16, BALATON Zoltan wrote: >>> >>> +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); >>> +    pci_ide_create_devs(pci_dev); >> >> Additionally, I think it may also make sense to move pci_ide_create_devs >> call into the realize methods of these

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-14 Thread Paolo Bonzini
On 13/03/20 23:16, BALATON Zoltan wrote: >> >> +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); >> +    pci_ide_create_devs(pci_dev); > > Additionally, I think it may also make sense to move pci_ide_create_devs > call into the realize methods of these IDE controllers so boards do not

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-13 Thread BALATON Zoltan
On Fri, 13 Mar 2020, BALATON Zoltan wrote: The pci_ide_create_devs() function takes a hd_table parameter but all callers just pass what ide_drive_get() returns so we can do it locally simplifying callers and removing hd_table parameter. Signed-off-by: BALATON Zoltan --- hw/alpha/dp264.c

[PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-13 Thread BALATON Zoltan
The pci_ide_create_devs() function takes a hd_table parameter but all callers just pass what ide_drive_get() returns so we can do it locally simplifying callers and removing hd_table parameter. Signed-off-by: BALATON Zoltan --- hw/alpha/dp264.c | 13 +++-- hw/i386/pc_piix.c