Re: [PATCH 65/70] target/xtensa: Use tcg_gen_subfi_i32 in translate_sll

[Philippe Mathieu-Daudé]

On 27/2/23 06:42, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  target/xtensa/translate.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 

Re: [PATCH 65/70] target/xtensa: Use tcg_gen_subfi_i32 in translate_sll

[Max Filippov]

On Sun, Feb 26, 2023 at 9:48 PM Richard Henderson
 wrote:
>
> Signed-off-by: Richard Henderson 
> ---
>  target/xtensa/translate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Max Filippov 

-- 
Thanks.
-- Max

[PATCH 65/70] target/xtensa: Use tcg_gen_subfi_i32 in translate_sll

[Richard Henderson]

Signed-off-by: Richard Henderson 
---
 target/xtensa/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 41b84082de..2903c73f8e 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -2324,8 +2324,8 @@ static void translate_sll(DisasContext *dc, const 
OpcodeArg arg[],
 tcg_gen_shl_i32(arg[0].out, arg[1].in, dc->sar_m32);
 } else {
 TCGv_i64 v = tcg_temp_new_i64();
-TCGv_i32 s = tcg_const_i32(32);
-tcg_gen_sub_i32(s, s, cpu_SR[SAR]);
+TCGv_i32 s = tcg_temp_new();
+tcg_gen_subfi_i32(s, 32, cpu_SR[SAR]);
 tcg_gen_andi_i32(s, s, 0x3f);
 tcg_gen_extu_i32_i64(v, arg[1].in);
 gen_shift_reg(shl, s);
-- 
2.34.1