Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-12-04 Thread Markus Armbruster
Eric Blake writes: > On 12/4/19 12:56 AM, Markus Armbruster wrote: > +++ b/Makefile @@ -130,6 +130,15 @@ GENERATED_QAPI_FILES += qapi/qapi-doc.texi generated-files-y += $(GENERATED_QAPI_FILES) +GENERATED_QGA_FILES := qga-qapi-types.c qga-qapi-types.h

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-12-04 Thread Eric Blake
On 12/4/19 12:56 AM, Markus Armbruster wrote: +++ b/Makefile @@ -130,6 +130,15 @@ GENERATED_QAPI_FILES += qapi/qapi-doc.texi generated-files-y += $(GENERATED_QAPI_FILES) +GENERATED_QGA_FILES := qga-qapi-types.c qga-qapi-types.h +GENERATED_QGA_FILES += qga-qapi-visit.c qga-qapi-visit.h

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-12-03 Thread Markus Armbruster
Eric Blake writes: > On 11/29/19 3:59 AM, Markus Armbruster wrote: >> Generated .h need to be generated before compiling any .c using them. >> To know which .h a .c uses, we need to compile it. >> >> Since commit 4115852bb0 "build: do not sprinkle around >> GENERATED_HEADERS dependencies", we

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-12-03 Thread Eric Blake
On 11/29/19 3:59 AM, Markus Armbruster wrote: Generated .h need to be generated before compiling any .c using them. To know which .h a .c uses, we need to compile it. Since commit 4115852bb0 "build: do not sprinkle around GENERATED_HEADERS dependencies", we break this circular dependency the

[PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-11-29 Thread Markus Armbruster
Generated .h need to be generated before compiling any .c using them. To know which .h a .c uses, we need to compile it. Since commit 4115852bb0 "build: do not sprinkle around GENERATED_HEADERS dependencies", we break this circular dependency the simple & stupid way: the generated headers are a