Re: [PATCH 7/8] configure, meson: move config-poison.h to meson

2021-12-21 Thread Richard Henderson

On 12/21/21 3:05 AM, Paolo Bonzini wrote:

+genh += custom_target('config-poison.h',
+  input: [target_configs_h],
+  output: 'config-poison.h',
+  capture: true,
+  command: [find_program('scripts/make-config-poison.sh')] 
+
+   (target_configs_h.length() > 0 ? ['@INPUT@'] : 
[]))


Using length + @INPUT@ seems needlessly around the bush.
Perhaps better as

  [find_program...] + target_configs_h

Otherwise it looks ok.


r~



[PATCH 7/8] configure, meson: move config-poison.h to meson

2021-12-21 Thread Paolo Bonzini
This ensures that the file is regenerated properly whenever config-target.h
or config-devices.h files change.

Signed-off-by: Paolo Bonzini 
---
 Makefile  |  2 +-
 configure | 11 ---
 meson.build   | 12 
 scripts/make-config-poison.sh | 16 
 4 files changed, 29 insertions(+), 12 deletions(-)
 create mode 100755 scripts/make-config-poison.sh

diff --git a/Makefile b/Makefile
index 06ad8a61e1..2f80f56a4a 100644
--- a/Makefile
+++ b/Makefile
@@ -220,7 +220,7 @@ qemu-%.tar.bz2:
 
 distclean: clean
-$(quiet-@)test -f build.ninja && $(NINJA) $(NINJAFLAGS) -t clean -g || 
:
-   rm -f config-host.mak config-poison.h
+   rm -f config-host.mak
rm -f tests/tcg/config-*.mak
rm -f config.status
rm -f roms/seabios/config.mak
diff --git a/configure b/configure
index 810bc36490..aff371ca81 100755
--- a/configure
+++ b/configure
@@ -3858,17 +3858,6 @@ if test -n "${deprecated_features}"; then
 echo "  features: ${deprecated_features}"
 fi
 
-# Create list of config switches that should be poisoned in common code...
-# but filter out CONFIG_TCG and CONFIG_USER_ONLY which are special.
-target_configs_h=$(ls *-config-devices.h *-config-target.h 2>/dev/null)
-if test -n "$target_configs_h" ; then
-sed -n -e '/CONFIG_TCG/d' -e '/CONFIG_USER_ONLY/d' \
--e '/^#define / { s///; s/ .*//; s/^/#pragma GCC poison /p; }' \
-$target_configs_h | sort -u > config-poison.h
-else
-:> config-poison.h
-fi
-
 # Save the configure command line for later reuse.
 cat  0 ? ['@INPUT@'] : 
[]))
+
 ##
 # Submodules #
 ##
diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
new file mode 100755
index 00..d222a04304
--- /dev/null
+++ b/scripts/make-config-poison.sh
@@ -0,0 +1,16 @@
+#! /bin/sh
+
+if test $# = 0; then
+  exit 0
+fi
+
+# Create list of config switches that should be poisoned in common code...
+# but filter out CONFIG_TCG and CONFIG_USER_ONLY which are special.
+exec sed -n \
+  -e' /CONFIG_TCG/d' \
+  -e '/CONFIG_USER_ONLY/d' \
+  -e '/^#define / {' \
+  -e's///' \
+  -e's/ .*//' \
+  -e's/^/#pragma GCC poison /p' \
+  -e '}' "$@"
-- 
2.33.1