[PATCH 71/76] target/sparc: Drop reset_sar_tracker

[Richard Henderson]

Translators are no longer required to free tcg temporaries.
Remove sar_m32_allocated, as sar_m32 non-null is equivalent.

Signed-off-by: Richard Henderson 
---
 target/xtensa/translate.c | 14 ++
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 4af0650deb..910350dec6 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -57,7 +57,6 @@ struct DisasContext {
 
 bool sar_5bit;
 bool sar_m32_5bit;
-bool sar_m32_allocated;
 TCGv_i32 sar_m32;
 
 unsigned window;
@@ -284,14 +283,7 @@ static void init_sar_tracker(DisasContext *dc)
 {
 dc->sar_5bit = false;
 dc->sar_m32_5bit = false;
-dc->sar_m32_allocated = false;
-}
-
-static void reset_sar_tracker(DisasContext *dc)
-{
-if (dc->sar_m32_allocated) {
-tcg_temp_free(dc->sar_m32);
-}
+dc->sar_m32 = NULL;
 }
 
 static void gen_right_shift_sar(DisasContext *dc, TCGv_i32 sa)
@@ -306,9 +298,8 @@ static void gen_right_shift_sar(DisasContext *dc, TCGv_i32 
sa)
 
 static void gen_left_shift_sar(DisasContext *dc, TCGv_i32 sa)
 {
-if (!dc->sar_m32_allocated) {
+if (!dc->sar_m32) {
 dc->sar_m32 = tcg_temp_new_i32();
-dc->sar_m32_allocated = true;
 }
 tcg_gen_andi_i32(dc->sar_m32, sa, 0x1f);
 tcg_gen_sub_i32(cpu_SR[SAR], tcg_constant_i32(32), dc->sar_m32);
@@ -1247,7 +1238,6 @@ static void xtensa_tr_tb_stop(DisasContextBase *dcbase, 
CPUState *cpu)
 {
 DisasContext *dc = container_of(dcbase, DisasContext, base);
 
-reset_sar_tracker(dc);
 if (dc->icount) {
 tcg_temp_free(dc->next_icount);
 }
-- 
2.34.1

Re: [PATCH 71/76] target/sparc: Drop reset_sar_tracker

[Max Filippov]

On Sat, Feb 25, 2023 at 1:20 AM Richard Henderson
 wrote:
>
> Translators are no longer required to free tcg temporaries.
> Remove sar_m32_allocated, as sar_m32 non-null is equivalent.
>
> Signed-off-by: Richard Henderson 
> ---
>  target/xtensa/translate.c | 14 ++
>  1 file changed, 2 insertions(+), 12 deletions(-)

There should be 'target/xtensa' in the subject.
Reviewed-by: Max Filippov 

-- 
Thanks.
-- Max