Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-15 Thread Greg Kurz
On Mon, 15 Mar 2021 17:07:50 +0100 Christian Schoenebeck wrote: > On Samstag, 13. März 2021 08:51:21 CET Greg Kurz wrote: > > On Sat, 13 Mar 2021 07:43:38 +0200 > > > > Mahmoud Mandour wrote: > > > Thanks for the fast review. I asked on the QEMU IRC channel > > > before committing whether to

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-15 Thread Christian Schoenebeck
On Samstag, 13. März 2021 08:51:21 CET Greg Kurz wrote: > On Sat, 13 Mar 2021 07:43:38 +0200 > > Mahmoud Mandour wrote: > > Thanks for the fast review. I asked on the QEMU IRC channel > > before committing whether to put all the changes into one patch > > or split them and was instructed that it

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-12 Thread Greg Kurz
On Sat, 13 Mar 2021 07:43:38 +0200 Mahmoud Mandour wrote: > Thanks for the fast review. I asked on the QEMU IRC channel > before committing whether to put all the changes into one patch > or split them and was instructed that it was better to split them up. > But in any case I was open to both

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-12 Thread Mahmoud Mandour
Thanks for the fast review. I asked on the QEMU IRC channel before committing whether to put all the changes into one patch or split them and was instructed that it was better to split them up. But in any case I was open to both ways and you can decide on the best way to go. On Thu, Mar 11, 2021

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-11 Thread Christian Schoenebeck
On Donnerstag, 11. März 2021 12:52:45 CET Greg Kurz wrote: > On Thu, 11 Mar 2021 11:49:06 +0100 > > Christian Schoenebeck wrote: > > On Donnerstag, 11. März 2021 04:15:37 CET Mahmoud Mandour wrote: > > > Replaced a call to qemu_mutex_lock and its respective call to > > > qemu_mutex_unlock and

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-11 Thread Greg Kurz
On Thu, 11 Mar 2021 11:49:06 +0100 Christian Schoenebeck wrote: > On Donnerstag, 11. März 2021 04:15:37 CET Mahmoud Mandour wrote: > > Replaced a call to qemu_mutex_lock and its respective call to > > qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. > > This simplifies the code

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-11 Thread Christian Schoenebeck
On Donnerstag, 11. März 2021 04:15:37 CET Mahmoud Mandour wrote: > Replaced a call to qemu_mutex_lock and its respective call to > qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. > This simplifies the code by removing the call required to unlock > and also eliminates goto paths. >

[PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-11 Thread Mahmoud Mandour
Replaced a call to qemu_mutex_lock and its respective call to qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. This simplifies the code by removing the call required to unlock and also eliminates goto paths. Signed-off-by: Mahmoud Mandour --- hw/9pfs/9p-synth.c | 12

Re: [PATCH 8/9] hw/9pfs/9p-synth: Replaced qemu_mutex_lock with QEMU_LOCK_GUARD

2021-03-10 Thread Greg Kurz
On Thu, 11 Mar 2021 05:15:37 +0200 Mahmoud Mandour wrote: > Replaced a call to qemu_mutex_lock and its respective call to > qemu_mutex_unlock and used QEMU_LOCK_GUARD macro in their place. > This simplifies the code by removing the call required to unlock > and also eliminates goto paths. > >