Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-12-04 Thread Shenming Lu
On 2020/12/2 18:55, Dr. David Alan Gilbert wrote: > * Shenming Lu (lushenm...@huawei.com) wrote: >> Hi, >> >> After reading everyone's opinions, we have a rough idea for this issue. >> >> One key point is whether it is necessary to setup the config space before >> the device can accept further

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-12-03 Thread Shenming Lu
On 2020/12/2 6:21, Alex Williamson wrote: > On Tue, 1 Dec 2020 14:37:52 +0800 > Shenming Lu wrote: > >> On 2020/12/1 1:03, Alex Williamson wrote: >>> On Thu, 26 Nov 2020 14:56:17 +0800 >>> Shenming Lu wrote: >>> Hi, After reading everyone's opinions, we have a rough idea for

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-12-02 Thread Dr. David Alan Gilbert
* Shenming Lu (lushenm...@huawei.com) wrote: > Hi, > > After reading everyone's opinions, we have a rough idea for this issue. > > One key point is whether it is necessary to setup the config space before > the device can accept further migration data. I think it is decided by > the vendor

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-12-01 Thread Alex Williamson
On Tue, 1 Dec 2020 14:37:52 +0800 Shenming Lu wrote: > On 2020/12/1 1:03, Alex Williamson wrote: > > On Thu, 26 Nov 2020 14:56:17 +0800 > > Shenming Lu wrote: > > > >> Hi, > >> > >> After reading everyone's opinions, we have a rough idea for this issue. > >> > >> One key point is whether it

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-30 Thread Shenming Lu
On 2020/12/1 1:03, Alex Williamson wrote: > On Thu, 26 Nov 2020 14:56:17 +0800 > Shenming Lu wrote: > >> Hi, >> >> After reading everyone's opinions, we have a rough idea for this issue. >> >> One key point is whether it is necessary to setup the config space before >> the device can accept

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-30 Thread Alex Williamson
On Thu, 26 Nov 2020 14:56:17 +0800 Shenming Lu wrote: > Hi, > > After reading everyone's opinions, we have a rough idea for this issue. > > One key point is whether it is necessary to setup the config space before > the device can accept further migration data. I think it is decided by > the

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-25 Thread Shenming Lu
Hi, After reading everyone's opinions, we have a rough idea for this issue. One key point is whether it is necessary to setup the config space before the device can accept further migration data. I think it is decided by the vendor driver, so we can simply ask the vendor driver about it in

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-24 Thread Dr. David Alan Gilbert
* Neo Jia (c...@nvidia.com) wrote: > On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: > > External email: Use caution opening links or attachments > > > > > > On 2020/11/21 6:01, Alex Williamson wrote: > > > On Fri, 20 Nov 2020 22:05:49 +0800 > > > Shenming Lu wrote: > > > > > >> On

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-24 Thread Shenming Lu
On 2020/11/24 3:33, Neo Jia wrote: > On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: >> External email: Use caution opening links or attachments >> >> >> On 2020/11/21 6:01, Alex Williamson wrote: >>> On Fri, 20 Nov 2020 22:05:49 +0800 >>> Shenming Lu wrote: >>> On 2020/11/20

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-23 Thread Alex Williamson
On Mon, 23 Nov 2020 11:33:37 -0800 Neo Jia wrote: > On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: > > External email: Use caution opening links or attachments > > > > > > On 2020/11/21 6:01, Alex Williamson wrote: > > > On Fri, 20 Nov 2020 22:05:49 +0800 > > > Shenming Lu

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-23 Thread Neo Jia
On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: > External email: Use caution opening links or attachments > > > On 2020/11/21 6:01, Alex Williamson wrote: > > On Fri, 20 Nov 2020 22:05:49 +0800 > > Shenming Lu wrote: > > > >> On 2020/11/20 1:41, Alex Williamson wrote: > >>> On

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-23 Thread Cornelia Huck
On Fri, 20 Nov 2020 15:01:46 -0700 Alex Williamson wrote: > Given our timing relative to QEMU 5.2, the only path I feel comfortable > with is to move forward with downgrading vfio migration support to be > enabled via an experimental option. Objections? Thanks, > > Alex Agreed from my side.

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-22 Thread Shenming Lu
On 2020/11/21 6:01, Alex Williamson wrote: > On Fri, 20 Nov 2020 22:05:49 +0800 > Shenming Lu wrote: > >> On 2020/11/20 1:41, Alex Williamson wrote: >>> On Thu, 19 Nov 2020 14:13:24 +0530 >>> Kirti Wankhede wrote: >>> On 11/14/2020 2:47 PM, Shenming Lu wrote: > When running VFIO

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-20 Thread Alex Williamson
On Fri, 20 Nov 2020 22:05:49 +0800 Shenming Lu wrote: > On 2020/11/20 1:41, Alex Williamson wrote: > > On Thu, 19 Nov 2020 14:13:24 +0530 > > Kirti Wankhede wrote: > > > >> On 11/14/2020 2:47 PM, Shenming Lu wrote: > >>> When running VFIO migration, I found that the restoring of VFIO PCI

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-20 Thread Shenming Lu
On 2020/11/20 1:41, Alex Williamson wrote: > On Thu, 19 Nov 2020 14:13:24 +0530 > Kirti Wankhede wrote: > >> On 11/14/2020 2:47 PM, Shenming Lu wrote: >>> When running VFIO migration, I found that the restoring of VFIO PCI device’s >>> config space is before VGIC on ARM64 target. But generally,

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-19 Thread Alex Williamson
On Thu, 19 Nov 2020 14:13:24 +0530 Kirti Wankhede wrote: > On 11/14/2020 2:47 PM, Shenming Lu wrote: > > When running VFIO migration, I found that the restoring of VFIO PCI device’s > > config space is before VGIC on ARM64 target. But generally, interrupt > > controllers > > need to be restored

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-19 Thread Kirti Wankhede
On 11/14/2020 2:47 PM, Shenming Lu wrote: When running VFIO migration, I found that the restoring of VFIO PCI device’s config space is before VGIC on ARM64 target. But generally, interrupt controllers need to be restored before PCI devices. Is there any other way by which VGIC can be

[PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-11-14 Thread Shenming Lu
When running VFIO migration, I found that the restoring of VFIO PCI device’s config space is before VGIC on ARM64 target. But generally, interrupt controllers need to be restored before PCI devices. Besides, if a VFIO PCI device is configured to have directly-injected MSIs (VLPIs), the restoring